opendev/gerrit
Code Issues Proposed changes

Disallow tabbing on paper-button

Browse Source 
Because you can already tab through gr-buttons, the paper-button made it
so that each button had two tabs. The tabindex should only be on the
gr-buttons, so disallow on paper-button. For easy demonstration of this
issue, try to tab through the labels on the reply dilog.

Change-Id: Ibc1e7d753f3cda1786d09f81433656c9d3282305
(cherry picked from commit 048e8dc960)
This commit is contained in:
Becky Siegel
2017-10-02 12:01:19 +01:00
committed by Paladox none
parent 525c98bf3d
commit f0ebfdcfc5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/shared/gr-button/gr-button.html
View File

@@ -116,7 +116,7 @@ limitations under the License.
color: #aaa;
}
</style>
<paper-button raised="[[!link]]" disabled="[[disabled]]">
<paper-button raised="[[!link]]" disabled="[[disabled]]" tabindex="-1">
<content></content>
<i class="downArrow"></i>
</paper-button>