opendev/gerrit
Code Issues Proposed changes

Remove references to unsupported IE6

Browse Source 
IE6 is no longer supported in target builds by GWT.
Remove the dead code, rename still live IE support to IE8.

Change-Id: I8d0f20ee09a687f2692e196d9f25cef928dc3bb4
This commit is contained in:
Shawn Pearce 2015-03-17 15:44:21 -07:00
parent eb7d88c1ec
commit f109bec92a
7 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/linker/server/UserAgentRule.java
View File

@ -67,9 +67,6 @@ public class UserAgentRule {
if (v >= 8000) {
return "ie8";
}
if (v >= 6000) {
return "ie6";
}
}
return null;

2
gerrit-gwtui/gwt.defs
View File

@ -17,7 +17,7 @@ BROWSERS = [
'firefox',
'gecko1_8',
'safari',
'msie', 'ie6', 'ie8', 'ie9',
'msie', 'ie8', 'ie9',
]
ALIASES = {
'chrome': 'safari',

4
gerrit-gwtui/src/main/java/com/google/gerrit/UserAgent.gwt.xml
View File

@ -21,10 +21,9 @@
<when-property-is name="user.agent" value="gecko1_8" />
</replace-with>
<replace-with class="com.google.gerrit.client.ui.FancyFlexTableImplIE6">
<replace-with class="com.google.gerrit.client.ui.FancyFlexTableImplIE8">
<when-type-is class="com.google.gerrit.client.ui.FancyFlexTableImpl" />
<any>
<when-property-is name="user.agent" value="ie6"/>
<when-property-is name="user.agent" value="ie8"/>
</any>
</replace-with>
@ -32,7 +31,6 @@
<replace-with class="com.google.gerrit.client.Themer.ThemerIE">
<when-type-is class="com.google.gerrit.client.Themer" />
<any>
<when-property-is name="user.agent" value="ie6"/>
<when-property-is name="user.agent" value="ie8"/>
<when-property-is name="user.agent" value="ie9"/>
<when-property-is name="user.agent" value="ie10"/>

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css
View File

@ -354,7 +354,7 @@ a:hover {
opacity: 0.80;
}
}
@if user.agent ie6 ie8 {
@if user.agent ie8 {
/* IE just doesn't do opacity the way we want, make our dialog
* stand out in a way that it can't be missed against the page
*/

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTableImplIE6.java → gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTableImplIE8.java
View File

@ -21,7 +21,7 @@ import com.google.gwt.user.client.ui.HTMLTable;
import com.google.gwtexpui.safehtml.client.SafeHtml;
import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
public class FancyFlexTableImplIE6 extends FancyFlexTableImpl {
public class FancyFlexTableImplIE8 extends FancyFlexTableImpl {
@Override
public void resetHtml(final FlexTable myTable, final SafeHtml bodyHtml) {
final Element oldBody = getBodyElement(myTable);

3
gerrit-prettify/src/main/java/com/google/gerrit/prettify/PrettyFormatter.gwt.xml
View File

@ -14,10 +14,9 @@
limitations under the License.
-->
<module>
<replace-with class='com.google.gerrit.prettify.client.PrivateScopeImplIE6'>
<replace-with class='com.google.gerrit.prettify.client.PrivateScopeImplIE8'>
<when-type-is class='com.google.gerrit.prettify.client.PrivateScopeImpl'/>
<any>
<when-property-is name="user.agent" value="ie6" />
<when-property-is name="user.agent" value="ie8" />
</any>
</replace-with>

4
gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrivateScopeImplIE6.java → gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrivateScopeImplIE8.java
View File

@ -16,8 +16,8 @@ package com.google.gerrit.prettify.client;
import com.google.gwt.core.client.JavaScriptObject;
/** IE6 requires us to initialize the document before we can use it. */
public class PrivateScopeImplIE6 extends PrivateScopeImpl {
/** MSIE requires us to initialize the document before we can use it. */
public class PrivateScopeImplIE8 extends PrivateScopeImpl {
private JavaScriptObject context;
@Override