From 0eeee76dc6453b07a2dd9b95b9c80d7c5c90ab54 Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Tue, 20 Aug 2013 10:59:39 +0200 Subject: [PATCH] Fix print out of warning if file of change index version is not a directory The condition to print out the warning 'exists && !f.isDirectory()' could never be true since 'exists' was only true if 'f.isDirectory()': boolean exists = f.exists() && f.isDirectory() Change-Id: I93f7b140c05e43e5af4a3083f69e913ecf8f6a84 Signed-off-by: Edwin Kempin --- .../java/com/google/gerrit/lucene/LuceneVersionManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java index 91dd01582e..337fa6d741 100644 --- a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java +++ b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java @@ -162,7 +162,7 @@ class LuceneVersionManager implements LifecycleListener { for (Schema schema : ChangeSchemas.ALL.values()) { File f = getDir(sitePaths, schema); boolean exists = f.exists() && f.isDirectory(); - if (exists && !f.isDirectory()) { + if (f.exists() && !f.isDirectory()) { log.warn("Not a directory: %s", f.getAbsolutePath()); } int v = schema.getVersion();