opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Only allow label scores on current revision

Browse Source 
Do not display labels for scoring on a non-current revision.  This is
confusing as there is relatively little to be gained from scoring an
out of date revision on a change.

Change-Id: Ib76a918f20becbde191b50892395ccb1992ee093
This commit is contained in:
Shawn Pearce
2013-07-19 17:01:12 -07:00
parent ce6c264029
commit f12c3da805
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java
View File

@@ -48,8 +48,9 @@ class ReplyAction {
this.style = style;
this.replyButton = replyButton;
boolean current = revision.equals(info.current_revision());
allLabels = info.all_labels();
permittedLabels = info.has_permitted_labels()
permittedLabels = current && info.has_permitted_labels()
? info.permitted_labels()
: NativeMap.<JsArrayString> create();
}