opendev/gerrit
Code Issues Proposed changes

Merge "Add TODOs for public ChangeControl methods used only for drafts"

Browse Source
This commit is contained in:
Edwin Kempin
2017-08-24 15:55:03 +00:00
committed by Gerrit Code Review
parent caa5f7824f 503d38450a
commit f14482cbb5
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java
View File

@@ -230,6 +230,7 @@ public class ChangeControl {
/** Can this user publish this draft change or any draft patch set of this change? */
public boolean canPublish(ReviewDb db) throws OrmException {
// TODO(hiesel) These don't need to be migrated, just remove after support for drafts is removed
return (isOwner() || getRefControl().canPublishDrafts()) && isVisible(db);
}
@@ -439,6 +440,7 @@ public class ChangeControl {
}
public boolean isDraftVisible(ReviewDb db, ChangeData cd) throws OrmException {
// TODO(hiesel) These don't need to be migrated, just remove after support for drafts is removed
return isOwner()
|| isReviewer(db, cd)
|| getRefControl().canViewDrafts()