opendev/gerrit
Code Issues Proposed changes

Only create All-Projects ACL once

Browse Source 
If refs/meta/config already exists do not overwrite or update it
with default configuration. This protects site administrators who
run `java -war gerrit.war init -d /some/existing/site --batch` and
corrupt ACLs of a live server with default settings.

To really set the default ACLs on an existing site the admin
should remove the refs/meta/config branch so it can be created.

Change-Id: I44a21b0c162812747ebcd50535709e8330dfbef8
This commit is contained in:
Shawn Pearce
2014-09-02 15:02:12 -07:00
parent 44bdf188c9
commit f179123563
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/AllProjectsCreator.java
View File

@@ -180,7 +180,7 @@ public class AllProjectsCreator {
grant(config, meta, Permission.PUSH, admin, owners);
grant(config, meta, Permission.SUBMIT, admin, owners);
config.commit(md);
config.commitToNewRef(md, RefNames.REFS_CONFIG);
}
private void grant(ProjectConfig config, AccessSection section,