opendev/gerrit
Code Issues Proposed changes

Change "Publish Comments" to "Review"

Browse Source 
The term "Publish Comments" was overloaded in the UI, we used it to
open the comment review screen, and we used it to actually mean send
the comments by email and make them visible to other users.  This is
confusing to users.

Call the first button "Review", making it more clear that the action
will bring up a screen that helps the user review their comments,
before they become visible to others.

Change-Id: I39eeda35915a775f601154992f77a986fcd32b69
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2010-02-01 00:05:50 -08:00
parent 7dafe19aee
commit f234bb8781
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
View File

@@ -94,7 +94,7 @@ public interface ChangeConstants extends Constants {
String headingAbandonMessage();
String abandonChangeTitle();
String buttonPublishCommentsBegin();
String buttonReview();
String buttonPublishCommentsSend();
String buttonPublishCommentsCancel();
String headingCoverMessage();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
View File

@@ -71,7 +71,7 @@ buttonAbandonChangeCancel = Cancel
headingAbandonMessage = Abandon Message:
abandonChangeTitle = Code Review - Abandon Change
buttonPublishCommentsBegin = Publish Comments
buttonReview = Review
buttonPublishCommentsSend = Publish Comments
buttonPublishCommentsCancel = Cancel
headingCoverMessage = Cover Message:

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetPanel.java
View File

@@ -110,7 +110,7 @@ class PatchSetPanel extends Composite implements OpenHandler<DisclosurePanel> {
actionsPanel.setStyleName(Gerrit.RESOURCES.css().patchSetActions());
body.add(actionsPanel);
if (Gerrit.isSignedIn()) {
populateCommentAction();
populateReviewAction();
if (changeDetail.isCurrentPatchSet(detail)) {
populateActions(detail);
}
@@ -291,8 +291,8 @@ class PatchSetPanel extends Composite implements OpenHandler<DisclosurePanel> {
}
}
private void populateCommentAction() {
final Button b = new Button(Util.C.buttonPublishCommentsBegin());
private void populateReviewAction() {
final Button b = new Button(Util.C.buttonReview());
b.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {