opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Hide reply box when leaving the screen

Browse Source 
If the reply box is open and the user clicks on a link to a
file with an inline comment, close the reply box. It should
not display over SideBySide2.

Change-Id: Idaed2f215181c75529f3cb1f3662cd7735a82dae
This commit is contained in:
Shawn Pearce
2013-12-05 11:16:31 -08:00
parent d688d36e89
commit f2997ab34c
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
View File

@@ -212,6 +212,9 @@ public class ChangeScreen2 extends Screen {
@Override @Override
protected void onUnload() { protected void onUnload() {
if (replyAction != null) {
replyAction.hide();
}
if (updateCheck != null) { if (updateCheck != null) {
updateCheck.cancel(); updateCheck.cancel();
updateCheck = null; updateCheck = null;

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java
View File

@@ -62,6 +62,13 @@ class ReplyAction {
: NativeMap.<JsArrayString> create(); : NativeMap.<JsArrayString> create();
} }
void hide() {
if (popup != null) {
popup.hide();
}
return;
}
void onReply(MessageInfo msg) { void onReply(MessageInfo msg) {
if (popup != null) { if (popup != null) {
popup.hide(); popup.hide();