opendev/gerrit
Code Issues Proposed changes

Leave assignee feature always enabled

Browse Source 
The assignee feature cannot be disabled and thus does not make
so much sense to just show and hide some parts of it here and there
on the Gerrit UX.

Leave only the possibility to enable/disable the display of
the assignee field as column in the changes table.

Change-Id: Icbfb93a49f29b2fde60b92b448862216861108d1
This commit is contained in:
Luca Milanesio
2017-04-10 10:59:34 +01:00
parent 70fbef858e
commit f2a275b82d
8 changed files with 11 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchSuggestOracle.java
View File

@@ -157,11 +157,9 @@ public class SearchSuggestOracle extends HighlightSuggestOracle {
suggestions.add("hashtag:");
}
if (Gerrit.info().change().showAssigneeSuggestOracle()) {
suggestions.add("is:assigned");
suggestions.add("is:unassigned");
suggestions.add("assignee:");
}
suggestions.add("is:assigned");
suggestions.add("is:unassigned");
suggestions.add("assignee:");
suggestions.add("AND");
suggestions.add("OR");

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPreferencesScreen.java
View File

@@ -156,7 +156,6 @@ public class MyPreferencesScreen extends SettingsScreen {
dateTimePanel.add(timeFormat);
}
highlightAssigneeInChangeTable = new CheckBox(Util.C.highlightAssigneeInChangeTable());
highlightAssigneeInChangeTable.setEnabled(Gerrit.info().change().showAssignee());
relativeDateInChangeTable = new CheckBox(Util.C.showRelativeDateInChangeTable());
sizeBarInChangeTable = new CheckBox(Util.C.showSizeBarInChangeTable());
legacycidInChangeTable = new CheckBox(Util.C.showLegacycidInChangeTable());
@@ -290,7 +289,7 @@ public class MyPreferencesScreen extends SettingsScreen {
maximumPageSize.setEnabled(on);
dateFormat.setEnabled(on);
timeFormat.setEnabled(on);
highlightAssigneeInChangeTable.setEnabled(Gerrit.info().change().showAssignee());
highlightAssigneeInChangeTable.setEnabled(on);
relativeDateInChangeTable.setEnabled(on);
sizeBarInChangeTable.setEnabled(on);
legacycidInChangeTable.setEnabled(on);

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen.java
View File

@@ -1324,12 +1324,7 @@ public class ChangeScreen extends Screen {
commit.set(commentLinkProcessor, info, revision);
related.set(info, revision);
reviewers.set(info);
if (Gerrit.info().change().showAssignee()
|| Gerrit.info().change().showAssigneeSuggestOracle()) {
assignee.set(info);
} else {
setVisible(assigneeRow, false);
}
assignee.set(info);
if (Gerrit.isNoteDbEnabled()) {
hashtags.set(info, revision);
} else {

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java
View File

@@ -80,7 +80,7 @@ public class ChangeTable extends NavigationTable<ChangeInfo> {
super(Util.C.changeItemHelp());
columns = BASE_COLUMNS;
labelNames = Collections.emptyList();
showAssignee = Gerrit.info().change().showAssignee();
showAssignee = Gerrit.info().change().showAssigneeInChangesTable();
showLegacyId = Gerrit.getUserPreferences().legacycidInChangeTable();
if (Gerrit.isSignedIn()) {