From f2ed2a668cc439680a97a925daafced08ce9dd7d Mon Sep 17 00:00:00 2001
From: David Pursehouse <dpursehouse@collab.net>
Date: Tue, 18 Oct 2016 08:49:54 +0900
Subject: [PATCH] ReceiveCommits: Fix Eclipse warnings

- Declaration of unthrown exception
- Unnecessarily nested else-clause

Change-Id: I199090caeda76574780029234dae018dde672ccb
---
 .../java/com/google/gerrit/server/git/ReceiveCommits.java  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
index 1fdddca231..74362b829e 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
@@ -1838,10 +1838,9 @@ public class ReceiveCommits {
                   "commit(s) already exists (as current patchset)");
               newChanges = Collections.emptyList();
               return;
-            } else {
-              itr.remove();
-              continue;
             }
+            itr.remove();
+            continue;
           }
           newChangeIds.add(p.changeKey);
         }
@@ -1897,7 +1896,7 @@ public class ReceiveCommits {
   }
 
   private boolean foundInExistingRef(Collection<Ref> existingRefs)
-      throws OrmException, IOException {
+      throws OrmException {
     for (Ref ref : existingRefs) {
       ChangeNotes notes = notesFactory.create(db, project.getNameKey(),
           Change.Id.fromRef(ref.getName()));