opendev/gerrit
Code Issues Proposed changes

Cannot Become Any Account for account whose full name is empty string

Browse Source 
If an account's full name is an empty string, it will not be selectable
on the development Become Any Account login screen.

Fix the account list population to also check if the full name is empty
before using it.  Thus, an account whose full name is empty will be
listed with either the preferred email address or ID.

Change-Id: Ica7b42def9c3816c233c03d1e2ca4b6889513fa9
This commit is contained in:
David Pursehouse
2013-04-26 10:59:24 +09:00
parent 6d0c32d0be
commit f3619bc452
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/become/BecomeAnyAccountLoginServlet.java
View File

@@ -173,7 +173,7 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
String displayName;
if (a.getUserName() != null) {
displayName = a.getUserName();
} else if (a.getFullName() != null) {
} else if (a.getFullName() != null && !a.getFullName().isEmpty()) {
displayName = a.getFullName();
} else if (a.getPreferredEmail() != null) {
displayName = a.getPreferredEmail();