opendev/gerrit
Code Issues Proposed changes

Remove unused code identified by Eclipse after refactorings

Browse Source 
Change-Id: I12b44e24ef4cbaaec625b486a5102971a2e55fd7
This commit is contained in:
Shawn Pearce
2017-08-07 13:49:52 -07:00
parent 355efd300a
commit f385dc0aa7
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java
View File

@@ -109,7 +109,6 @@ public class ApprovalsUtil {
private final NotesMigration migration; private final NotesMigration migration;
private final IdentifiedUser.GenericFactory userFactory; private final IdentifiedUser.GenericFactory userFactory;
private final ChangeControl.GenericFactory changeControlFactory;
private final ApprovalCopier copier; private final ApprovalCopier copier;
private final PermissionBackend permissionBackend; private final PermissionBackend permissionBackend;
@@ -118,12 +117,10 @@ public class ApprovalsUtil {
public ApprovalsUtil( public ApprovalsUtil(
NotesMigration migration, NotesMigration migration,
IdentifiedUser.GenericFactory userFactory, IdentifiedUser.GenericFactory userFactory,
ChangeControl.GenericFactory changeControlFactory,
ApprovalCopier copier, ApprovalCopier copier,
PermissionBackend permissionBackend) { PermissionBackend permissionBackend) {
this.migration = migration; this.migration = migration;
this.userFactory = userFactory; this.userFactory = userFactory;
this.changeControlFactory = changeControlFactory;
this.copier = copier; this.copier = copier;
this.permissionBackend = permissionBackend; this.permissionBackend = permissionBackend;
} }

2
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
View File

@@ -339,7 +339,7 @@ public class PostReviewers
ReviewerState state, ReviewerState state,
NotifyHandling notify, NotifyHandling notify,
ListMultimap<RecipientType, Account.Id> accountsToNotify) ListMultimap<RecipientType, Account.Id> accountsToNotify)
throws OrmException, PermissionBackendException { throws PermissionBackendException {
if (!permissionBackend if (!permissionBackend
.user(anonymousProvider) .user(anonymousProvider)
.change(rsrc.getNotes()) .change(rsrc.getNotes())