opendev/gerrit
Code Issues Proposed changes

Remove duplicate ref update commands for new change

Browse Source 
In ReceiveCommits, the ref updates are handled together in a
BatchRefUpdate(batch.addCommand(create.cmd)), no need to add the
ReceiveCommand into the ChangeInserter.

Change-Id: Ic888248f1fec27a5f9d84afc85ac035eecfa6607
This commit is contained in:
Zhen Chen
2016-09-23 15:21:12 -07:00
parent cb51d7465a
commit f38969d6dd
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -2012,7 +2012,6 @@ public class ReceiveCommits {
} }
cmd = new ReceiveCommand(ObjectId.zeroId(), commit, cmd = new ReceiveCommand(ObjectId.zeroId(), commit,
ins.getPatchSetId().toRefName()); ins.getPatchSetId().toRefName());
ins.setUpdateRefCommand(cmd);
if (rp.getPushCertificate() != null) { if (rp.getPushCertificate() != null) {
ins.setPushCertificate(rp.getPushCertificate().toTextWithSignature()); ins.setPushCertificate(rp.getPushCertificate().toTextWithSignature());
} }
@@ -2051,7 +2050,7 @@ public class ReceiveCommits {
.setNotify(magicBranch.notify) .setNotify(magicBranch.notify)
.setRequestScopePropagator(requestScopePropagator) .setRequestScopePropagator(requestScopePropagator)
.setSendMail(true) .setSendMail(true)
.setUpdateRef(true)); .setUpdateRef(false));
if (!magicBranch.hashtags.isEmpty()) { if (!magicBranch.hashtags.isEmpty()) {
bu.addOp( bu.addOp(
changeId, changeId,