From f6a3cb127cb9dbaaaf935d67f02d47d0b9c5d431 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 14 Jun 2017 21:32:57 +0900 Subject: [PATCH] ProjectTagsScreen: Fix title of revision field for new tag The UI for tag creation was based on the existing UI for branch creation, and the field is named "Initial Revision". "Initial Revision" makes sense for branches, where the revision of the branch may advance as changes are submitted. However, it does not make sense for tags, whose revision will not change. Change the title to only "Revision". Change-Id: I5c5ee711da7ef196f8a7398f5b479f8c0f31d302 --- .../java/com/google/gerrit/client/admin/AdminConstants.java | 2 ++ .../com/google/gerrit/client/admin/AdminConstants.properties | 1 + .../java/com/google/gerrit/client/admin/ProjectTagsScreen.java | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.java index d7fb0726e0..cc6a13671a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.java @@ -179,6 +179,8 @@ public interface AdminConstants extends Constants { String initialRevision(); + String revision(); + String buttonAddBranch(); String buttonDeleteBranch(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties index 465bcfc054..1588ea6afa 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties @@ -85,6 +85,7 @@ columnBranchRevision = Revision columnTagName = Tag Name columnTagRevision = Revision initialRevision = Initial Revision +revision = Revision buttonAddBranch = Create Branch buttonAddTag = Create Tag buttonDeleteBranch = Delete diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectTagsScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectTagsScreen.java index b89139c21f..f38d36cf9c 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectTagsScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectTagsScreen.java @@ -150,7 +150,7 @@ public class ProjectTagsScreen extends PaginatedProjectScreen { } } }); - addGrid.setText(1, 0, AdminConstants.I.initialRevision() + ":"); + addGrid.setText(1, 0, AdminConstants.I.revision() + ":"); addGrid.setWidget(1, 1, irevTxtBox); addTag = new Button(AdminConstants.I.buttonAddTag());