Fixes to match internal google rules

Change-Id: I1eb3173bf91964f743f7fc460350019d0e4ce8db
This commit is contained in:
Dmitrii Filippov
2020-08-19 12:25:36 +02:00
parent 09401651d8
commit f6ab749bcf
3 changed files with 8 additions and 3 deletions

View File

@@ -127,7 +127,7 @@ class GrRepoPluginConfig extends GestureEventListeners(
}
_computeChecked(value = 'false') {
return JSON.parse(value);
return JSON.parse(value) as boolean;
}
_handleStringChange(e: Event) {

View File

@@ -22,8 +22,13 @@ import {
} from '../services/gr-reporting/gr-reporting_impl';
import {appContext} from '../services/app-context';
interface UninitializedPolymer {
lazyRegister: boolean;
}
if (!window.Polymer) {
window.Polymer = {
// Without as... it violates internal google rules.
(window.Polymer as UninitializedPolymer) = {
lazyRegister: true,
};
}

View File

@@ -64,7 +64,7 @@ export class GrSettingsApi {
this.plugin.hook('settings-menu-item').onAttached(el => {
const menuItem = document.createElement('gr-settings-menu-item');
menuItem.title = this._title;
menuItem.href = `#${token}`;
menuItem.setAttribute('href', `#${token}`);
el.appendChild(menuItem);
});
const moduleName = this._moduleName;