opendev/gerrit
Code Issues Proposed changes

Remove errFn from save(|Diff|Edit)Preferences

Browse Source 
Change-Id: Id0f7deac5971296f3c8bef1f09a3d0435ca173cc
This commit is contained in:
Ben Rohlfs
2020-12-04 08:15:07 +01:00
parent 9501f90d88
commit f6fe5ab98e
2 changed files with 3 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts
View File

@@ -748,14 +748,7 @@ export class GrRestApiInterface
});
}
savePreferences(prefs: PreferencesInput): Promise<Response>;
savePreferences(
prefs: PreferencesInput,
errFn: ErrorCallback
): Promise<Response | undefined>;
savePreferences(prefs: PreferencesInput, errFn?: ErrorCallback) {
savePreferences(prefs: PreferencesInput): Promise<Response> {
// Note (Issue 5142): normalize the download scheme with lower case before
// saving.
if (prefs.download_scheme) {
@@ -766,45 +759,28 @@ export class GrRestApiInterface
method: HttpMethod.PUT,
url: '/accounts/self/preferences',
body: prefs,
errFn,
reportUrlAsIs: true,
});
}
saveDiffPreferences(prefs: DiffPreferenceInput): Promise<Response>;
saveDiffPreferences(
prefs: DiffPreferenceInput,
errFn: ErrorCallback
): Promise<Response | undefined>;
saveDiffPreferences(prefs: DiffPreferenceInput, errFn?: ErrorCallback) {
saveDiffPreferences(prefs: DiffPreferenceInput): Promise<Response> {
// Invalidate the cache.
this._cache.delete('/accounts/self/preferences.diff');
return this._restApiHelper.send({
method: HttpMethod.PUT,
url: '/accounts/self/preferences.diff',
body: prefs,
errFn,
reportUrlAsIs: true,
});
}
saveEditPreferences(prefs: EditPreferencesInfo): Promise<Response>;
saveEditPreferences(
prefs: EditPreferencesInfo,
errFn: ErrorCallback
): Promise<Response | undefined>;
saveEditPreferences(prefs: EditPreferencesInfo, errFn?: ErrorCallback) {
saveEditPreferences(prefs: EditPreferencesInfo): Promise<Response> {
// Invalidate the cache.
this._cache.delete('/accounts/self/preferences.edit');
return this._restApiHelper.send({
method: HttpMethod.PUT,
url: '/accounts/self/preferences.edit',
body: prefs,
errFn,
reportUrlAsIs: true,
});
}

16
polygerrit-ui/app/services/services/gr-rest-api/gr-rest-api.ts
View File

@@ -232,26 +232,10 @@ export interface RestApiService {
getDiffPreferences(): Promise<DiffPreferencesInfo | undefined>;
saveDiffPreferences(prefs: DiffPreferenceInput): Promise<Response>;
saveDiffPreferences(
prefs: DiffPreferenceInput,
errFn: ErrorCallback
): Promise<Response | undefined>;
saveDiffPreferences(
prefs: DiffPreferenceInput,
errFn?: ErrorCallback
): Promise<Response>;
getEditPreferences(): Promise<EditPreferencesInfo | undefined>;
saveEditPreferences(prefs: EditPreferencesInfo): Promise<Response>;
saveEditPreferences(
prefs: EditPreferencesInfo,
errFn: ErrorCallback
): Promise<Response | undefined>;
saveEditPreferences(
prefs: EditPreferencesInfo,
errFn?: ErrorCallback
): Promise<Response>;
getAccountEmails(): Promise<EmailInfo[] | undefined>;
deleteAccountEmail(email: string): Promise<Response>;