opendev/gerrit
Code Issues Proposed changes

Remove unnecessary GerritServer field in Receive command

Browse Source 
This is already being setup in the super class, as a protected field
we inherit, thus our field here was shadowing it.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-07-28 10:18:44 -07:00
parent b2e0a1a2d9
commit f722b5ca86
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/com/google/gerrit/server/ssh/Receive.java
View File

@@ -43,7 +43,6 @@ import com.google.gerrit.client.rpc.Common;
import com.google.gerrit.git.PatchSetImporter; import com.google.gerrit.git.PatchSetImporter;
import com.google.gerrit.git.PushQueue; import com.google.gerrit.git.PushQueue;
import com.google.gerrit.server.ChangeUtil; import com.google.gerrit.server.ChangeUtil;
import com.google.gerrit.server.GerritServer;
import com.google.gerrit.server.mail.CreateChangeSender; import com.google.gerrit.server.mail.CreateChangeSender;
import com.google.gerrit.server.mail.EmailException; import com.google.gerrit.server.mail.EmailException;
import com.google.gerrit.server.mail.MergedSender; import com.google.gerrit.server.mail.MergedSender;
@@ -128,7 +127,6 @@ class Receive extends AbstractGitCommand {
} }
} }
private GerritServer server;
private ReceivePack rp; private ReceivePack rp;
private PersonIdent refLogIdent; private PersonIdent refLogIdent;
private ReceiveCommand newChange; private ReceiveCommand newChange;
@@ -146,12 +144,6 @@ class Receive extends AbstractGitCommand {
private Map<ObjectId, Ref> refsById; private Map<ObjectId, Ref> refsById;
@Override
protected void preRun() throws Failure {
super.preRun();
server = getGerritServer();
}
@Override @Override
protected void runImpl() throws IOException, Failure { protected void runImpl() throws IOException, Failure {
if (Common.getGerritConfig().isUseContributorAgreements() if (Common.getGerritConfig().isUseContributorAgreements()