diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java index 2ffa7c5d9e..2070200d2e 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java @@ -81,6 +81,7 @@ public class UserAgent { try { return Integer.parseInt(p); } catch (NumberFormatException nan) { + // Ignored } } return -1; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/NpIntTextBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/NpIntTextBox.java index b57a58e46f..0933153a19 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/NpIntTextBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/NpIntTextBox.java @@ -89,6 +89,7 @@ public class NpIntTextBox extends NpTextBox { try { intValue = Integer.parseInt(getText()); } catch (NumberFormatException e) { + // Ignored } } return intValue; diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Gsql.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Gsql.java index a5ce9081c4..5c7f18bf7b 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Gsql.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Gsql.java @@ -52,6 +52,7 @@ public class Gsql extends SiteProgram { try { System.in.close(); } catch (IOException e) { + // Ignored } manager.stop(); } diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java index e2775c14dd..a77bcfab02 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java @@ -170,6 +170,7 @@ public class Init extends BaseInit { try { proc.getOutputStream().close(); } catch (IOException e) { + // Ignored } IoUtil.copyWithThread(proc.getInputStream(), System.err); diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Browser.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Browser.java index 98bee3deec..41cb87e2b5 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Browser.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Browser.java @@ -75,6 +75,7 @@ public class Browser { try { Thread.sleep(100); } catch (InterruptedException ie) { + // Ignored } continue; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java index 38fda4cceb..cf6c27e422 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java @@ -154,6 +154,7 @@ public class CreateAccount implements RestModifyView { try { db.accountExternalIds().delete(Collections.singleton(extUser)); } catch (OrmException cleanupError) { + // Ignored } throw new UnprocessableEntityException( "email '" + input.email + "' already exists"); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java index 966c77ac86..e830cfc7ad 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java @@ -263,6 +263,7 @@ import javax.security.auth.login.LoginException; recursivelyExpandGroups(groupDNs, schema, ctx, nextDN); } } catch (PartialResultException e) { + // Ignored } } } @@ -298,6 +299,7 @@ import javax.security.auth.login.LoginException; dns.add((String) groups.next()); } } catch (PartialResultException e) { + // Ignored } } } catch (NamingException e) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java index 1f6801162c..e9ae8f529f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java @@ -75,6 +75,7 @@ class LdapQuery { r.add(new Result(res.next())); } } catch (PartialResultException e) { + // Ignored } return r; } finally { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/GetSummary.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/GetSummary.java index 48fe57f90d..c99a3af4bb 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/GetSummary.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/GetSummary.java @@ -187,6 +187,7 @@ public class GetSummary implements RestReadView { try { jvmSummary.host = InetAddress.getLocalHost().getHostName(); } catch (UnknownHostException e) { + // Ignored } jvmSummary.currentWorkingDirectory = diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java index 2b1e3dddfa..5aef5bdc20 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java @@ -367,6 +367,7 @@ public class EventFactory { patchSetAttribute.files.add(p); } } catch (PatchListNotAvailableException e) { + log.warn("Cannot get patch list", e); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java index 9bb0816e01..8948ce3f7c 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java @@ -109,11 +109,11 @@ public abstract class ChangeEmail extends NotificationEmail { for (Account.Id who : changeData.reviewers().values()) { names.add(getNameEmailFor(who)); } - for (String name : names) { appendText("Gerrit-Reviewer: " + name + "\n"); } } catch (OrmException e) { + log.warn("Cannot get change reviewers", e); } formatFooter(); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java index 9baada5f87..785093a054 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java @@ -278,6 +278,7 @@ public class SmtpEmailSender implements EmailSender { try { client.disconnect(); } catch (IOException e2) { + //Ignored } } throw new EmailException(e.getMessage(), e); @@ -286,6 +287,7 @@ public class SmtpEmailSender implements EmailSender { try { client.disconnect(); } catch (IOException e2) { + // Ignored } } throw e; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginCleanerTask.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginCleanerTask.java index c13c5337ca..6c4c4513b2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginCleanerTask.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginCleanerTask.java @@ -45,6 +45,7 @@ class PluginCleanerTask implements Runnable { Thread.sleep(50); } } catch (InterruptedException e) { + // Ignored } int left = loader.processPendingCleanups(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginScannerThread.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginScannerThread.java index a484c5d44b..e6c3dbd651 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginScannerThread.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginScannerThread.java @@ -37,6 +37,7 @@ class PluginScannerThread extends Thread { return; } } catch (InterruptedException e) { + // Ignored } loader.rescan(); } @@ -47,6 +48,7 @@ class PluginScannerThread extends Thread { try { join(); } catch (InterruptedException e) { + // Ignored } } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsVisibleToPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsVisibleToPredicate.java index 7f91699460..dc7a5796e8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsVisibleToPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsVisibleToPredicate.java @@ -65,6 +65,7 @@ class IsVisibleToPredicate extends OperatorPredicate { return true; } } catch (NoSuchChangeException e) { + // Ignored } return false; } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java index 6d7ad0f237..a84570b602 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java @@ -356,6 +356,7 @@ public abstract class BaseCommand implements Command { err.write((f.getMessage() + "\n").getBytes(ENC)); err.flush(); } catch (IOException e2) { + // Ignored } catch (Throwable e2) { log.warn("Cannot send failure message to client", e2); } @@ -366,6 +367,7 @@ public abstract class BaseCommand implements Command { err.write("fatal: internal server error\n".getBytes(ENC)); err.flush(); } catch (IOException e2) { + // Ignored } catch (Throwable e2) { log.warn("Cannot send internal server error message to client", e2); } @@ -450,10 +452,12 @@ public abstract class BaseCommand implements Command { try { out.flush(); } catch (Throwable e2) { + // Ignored } try { err.flush(); } catch (Throwable e2) { + // Ignored } rc = handleError(e); } finally { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java index a63abee73b..0207ede598 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java @@ -187,6 +187,7 @@ class NoShell implements Factory { try { return new URL(url).getHost(); } catch (MalformedURLException e) { + // Ignored } } return SystemReader.getInstance().getHostname(); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginInstallCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginInstallCommand.java index 799686d656..5d6621f48e 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginInstallCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginInstallCommand.java @@ -107,6 +107,7 @@ final class PluginInstallCommand extends SshCommand { try { data.close(); } catch (IOException err) { + // Ignored } } } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java index bc820a4bc7..1ca4c8c6fe 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java @@ -361,6 +361,7 @@ public class ReviewCommand extends SshCommand { try { err.write(msg.getBytes(ENC)); } catch (IOException e) { + // Ignored } } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java index 852105847a..e9043f7fae 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java @@ -270,6 +270,7 @@ public class SetReviewersCommand extends SshCommand { try { err.write((type + ": " + msg + "\n").getBytes(ENC)); } catch (IOException e) { + // Ignored } }