opendev/gerrit
Code Issues Proposed changes

Use refs/meta/gpg-keys for GPG public keys

Browse Source 
Current C git client silently ignores refs in a ref advertisement with
a single slash, like refs/gpg-keys. This causes the client to send ref
updates as a create, which uses the wrong old object ID and fails with
a lock failure when the server tries to update the ref. Considering
that currently the only way to populate the GPG key ref is manually,
it would be nice to be able to push to that ref.

Change-Id: I83a3518d11a283b7fb0c31ebbf9e19a3d65886aa
This commit is contained in:
Dave Borowitz
2015-07-07 16:31:58 -04:00
parent 322db679f5
commit f75ad80882
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/RefNames.java
View File

@@ -61,7 +61,7 @@ public class RefNames {
* Special ref for GPG public keys used by {@link
* com.google.gerrit.server.git.SignedPushPreReceiveHook}.
*/
public static final String REFS_GPG_KEYS = REFS + "gpg-keys";
public static final String REFS_GPG_KEYS = "refs/meta/gpg-keys";
public static String fullName(String ref) {
return ref.startsWith(REFS) ? ref : REFS_HEADS + ref;