Cleanup old java_library2 buck targets.

We used to have //gerrit-gwtui-common:client-lib2 and
//gerrit-plugin-gwtui:gwtui-api-lib2 as java_library2 targets, and
//gerrit-gwtui-common:client-lib & //gerrit-plugin-gwtui:gwtui-api-lib
as java_library targets. Now they are all java_library targets, I don't
think the *2 targets are still needed any more.

Change-Id: I27c8347c415bb918827ca75c53736cf5622954be

gerrit-gwtui-common/BUCK

@@ -22,12 +22,6 @@ gwt_module(
 
 java_library(
   name = 'client-lib',
-  exported_deps = [':client-lib2'],
-  visibility = ['PUBLIC'],
-)
-
-java_library(
-  name = 'client-lib2',
   srcs = glob(['src/main/**/*.java']),
   resources = glob(['src/main/**/*']),
   exported_deps = EXPORTED_DEPS,

gerrit-plugin-gwtui/BUCK

@@ -16,15 +16,9 @@ java_binary(
 
 java_library(
   name = 'gwtui-api-lib',
-  exported_deps = [':gwtui-api-lib2'],
-  visibility = ['PUBLIC'],
-)
-
-java_library(
-  name = 'gwtui-api-lib2',
   srcs = SRCS,
   resources = glob(['src/main/**/*']),
-  exported_deps = ['//gerrit-gwtui-common:client-lib2'],
+  exported_deps = ['//gerrit-gwtui-common:client-lib'],
   provided_deps = DEPS + ['//lib/gwt:dev'],
   visibility = ['PUBLIC'],
 )
@@ -62,7 +56,7 @@ java_doc(
     '//lib:gwtjsonrpc',
     '//lib:gwtorm_client',
     '//lib/gwt:dev__jar',
-    '//gerrit-gwtui-common:client-lib2',
+    '//gerrit-gwtui-common:client-lib',
     '//gerrit-common:client',
     '//gerrit-reviewdb:client',
   ],