From f8da693c649280f9c927248f8fb21c4ad0074bc5 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Tue, 25 Oct 2016 14:28:53 +0900 Subject: [PATCH] TestAccount: Use Java 8 streams instead of FluentIterable Change-Id: I218460336635db552ca13723876cc83d13be2a29 --- .../google/gerrit/acceptance/TestAccount.java | 17 +++++++++-------- .../gerrit/acceptance/api/group/GroupsIT.java | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/TestAccount.java b/gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/TestAccount.java index c1a815a6f1..63e0fa78ef 100644 --- a/gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/TestAccount.java +++ b/gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/TestAccount.java @@ -14,7 +14,8 @@ package com.google.gerrit.acceptance; -import com.google.common.collect.FluentIterable; +import static java.util.stream.Collectors.toList; + import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.server.mail.Address; @@ -24,22 +25,22 @@ import org.eclipse.jgit.lib.PersonIdent; import java.io.ByteArrayOutputStream; import java.util.Arrays; +import java.util.List; public class TestAccount { - public static FluentIterable ids( - Iterable accounts) { - return FluentIterable.from(accounts).transform(a -> a.id); + public static List ids(List accounts) { + return accounts.stream().map(a -> a.id).collect(toList()); } - public static FluentIterable ids(TestAccount... accounts) { + public static List ids(TestAccount... accounts) { return ids(Arrays.asList(accounts)); } - public static FluentIterable names(Iterable accounts) { - return FluentIterable.from(accounts).transform(a -> a.fullName); + public static List names(List accounts) { + return accounts.stream().map(a -> a.fullName).collect(toList()); } - public static FluentIterable names(TestAccount... accounts) { + public static List names(TestAccount... accounts) { return names(Arrays.asList(accounts)); } diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/group/GroupsIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/group/GroupsIT.java index 78c0cdaaa3..241e1b98fb 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/group/GroupsIT.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/group/GroupsIT.java @@ -504,7 +504,7 @@ public class GroupsIT extends AbstractDaemonTest { throws Exception { assertMembers( gApi.groups().id(group).members(), - TestAccount.names(expectedMembers).toArray(String.class)); + TestAccount.names(expectedMembers).stream().toArray(String[]::new)); assertAccountInfos( Arrays.asList(expectedMembers), gApi.groups().id(group).members());