From f90bcdc7afc7deef14db67cb36671ddabc34fcb5 Mon Sep 17 00:00:00 2001 From: Michael Zhou Date: Sun, 8 Dec 2013 05:00:47 -0500 Subject: [PATCH] ChangeScreen2: Fix position of ReplyBox Currently, ReplyBox is misplaced or even missing when the page is not scrolled to the top. Fix by scrolling the page to the top before showing the PopupPanel. Change-Id: Iea04ac40855a2588fc6eec9adca46fd11fcf937a --- .../main/java/com/google/gerrit/client/change/ReplyAction.java | 2 ++ .../src/main/java/com/google/gerrit/client/change/ReplyBox.java | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java index 26e3b746ba..be1e217c67 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java @@ -23,6 +23,7 @@ import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gwt.core.client.JsArrayString; import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseHandler; +import com.google.gwt.user.client.Window; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.GlobalKey; @@ -101,6 +102,7 @@ class ReplyAction { } }); p.add(replyBox); + Window.scrollTo(0, 0); p.showRelativeTo(replyButton); GlobalKey.dialog(p); popup = p; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java index e1a439fb8e..3cf7ef08e0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java @@ -49,7 +49,6 @@ import com.google.gwt.resources.client.CssResource; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; import com.google.gwt.uibinder.client.UiHandler; -import com.google.gwt.user.client.Window; import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.CheckBox; @@ -154,7 +153,6 @@ class ReplyBox extends Composite { Scheduler.get().scheduleDeferred(new ScheduledCommand() { @Override public void execute() { - Window.scrollTo(0, 0); message.setFocus(true); }}); Scheduler.get().scheduleFixedDelay(new RepeatingCommand() {