opendev/gerrit
Code Issues Proposed changes

Remove redundant 'private' modifier on constructors

Browse Source 
Enum constructors are by default private, so it is not necessary
to explicitly declare them as so.

Change-Id: I871a84ef4950882a27b1d808e68af588a66fbdea
This commit is contained in:
David Pursehouse
2016-04-11 20:27:10 +09:00
committed by Michael Zhou
parent ad0e4bfe7d
commit f9a0cab3ba
11 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/GerritTopMenu.java
View File

@@ -19,7 +19,7 @@ public enum GerritTopMenu {
public final String menuName; public final String menuName;
private GerritTopMenu() { GerritTopMenu() {
menuName = name().substring(0, 1) + name().substring(1).toLowerCase(); menuName = name().substring(0, 1) + name().substring(1).toLowerCase();
} }
} }

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/ListChangesOption.java
View File

@@ -70,7 +70,7 @@ public enum ListChangesOption {
private final int value; private final int value;
private ListChangesOption(int v) { ListChangesOption(int v) {
this.value = v; this.value = v;
} }

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/ListGroupsOption.java
View File

@@ -26,7 +26,7 @@ public enum ListGroupsOption {
private final int value; private final int value;
private ListGroupsOption(int v) { ListGroupsOption(int v) {
this.value = v; this.value = v;
} }

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java
View File

@@ -137,7 +137,7 @@ public class RelatedChanges extends TabPanel {
abstract String getTitle(int count); abstract String getTitle(int count);
abstract String getTitle(String count); abstract String getTitle(String count);
private Tab(String defaultTitle, String tooltip) { Tab(String defaultTitle, String tooltip) {
this.defaultTitle = defaultTitle; this.defaultTitle = defaultTitle;
this.tooltip = tooltip; this.tooltip = tooltip;
} }

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Change.java
View File

@@ -356,7 +356,7 @@ public final class Change {
private final boolean closed; private final boolean closed;
private final ChangeStatus changeStatus; private final ChangeStatus changeStatus;
private Status(char c, ChangeStatus cs) { Status(char c, ChangeStatus cs) {
code = c; code = c;
closed = !(MIN_OPEN <= c && c <= MAX_OPEN); closed = !(MIN_OPEN <= c && c <= MAX_OPEN);
changeStatus = cs; changeStatus = cs;

4
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Patch.java
View File

@@ -89,7 +89,7 @@ public final class Patch {
private final char code; private final char code;
private ChangeType(final char c) { ChangeType(final char c) {
code = c; code = c;
} }
@@ -148,7 +148,7 @@ public final class Patch {
private final char code; private final char code;
private PatchType(final char c) { PatchType(final char c) {
code = c; code = c;
} }

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/PatchLineComment.java
View File

@@ -67,7 +67,7 @@ public final class PatchLineComment {
private final char code; private final char code;
private Status(final char c) { Status(final char c) {
code = c; code = c;
} }

2
gerrit-server/src/main/java/com/google/gerrit/server/change/ArchiveFormat.java
View File

@@ -31,7 +31,7 @@ public enum ArchiveFormat {
private final ArchiveCommand.Format<?> format; private final ArchiveCommand.Format<?> format;
private final String mimeType; private final String mimeType;
private ArchiveFormat(String mimeType, ArchiveCommand.Format<?> format) { ArchiveFormat(String mimeType, ArchiveCommand.Format<?> format) {
this.format = format; this.format = format;
this.mimeType = mimeType; this.mimeType = mimeType;
ArchiveCommand.registerFormat(name(), format); ArchiveCommand.registerFormat(name(), format);

2
gerrit-server/src/main/java/com/google/gerrit/server/change/GetDiff.java
View File

@@ -403,7 +403,7 @@ public class GetDiff implements RestReadView<FileResource> {
private final DiffPreferencesInfo.Whitespace whitespace; private final DiffPreferencesInfo.Whitespace whitespace;
private IgnoreWhitespace(DiffPreferencesInfo.Whitespace whitespace) { IgnoreWhitespace(DiffPreferencesInfo.Whitespace whitespace) {
this.whitespace = whitespace; this.whitespace = whitespace;
} }
} }

2
gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/CommitMergeStatus.java
View File

@@ -59,7 +59,7 @@ public enum CommitMergeStatus {
private String message; private String message;
private CommitMergeStatus(String message) { CommitMergeStatus(String message) {
this.message = message; this.message = message;
} }

2
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ReviewerStateInternal.java
View File

@@ -49,7 +49,7 @@ public enum ReviewerStateInternal {
private final FooterKey footerKey; private final FooterKey footerKey;
private final ReviewerState state; private final ReviewerState state;
private ReviewerStateInternal(FooterKey footerKey, ReviewerState state) { ReviewerStateInternal(FooterKey footerKey, ReviewerState state) {
this.footerKey = footerKey; this.footerKey = footerKey;
this.state = state; this.state = state;
} }