opendev/gerrit
Code Issues Proposed changes

Merge "ChangeScreen2: Fix bouncing Files header"

Browse Source
This commit is contained in:
Shawn Pearce
2013-12-09 16:19:20 +00:00
committed by Gerrit Code Review
parent 73f3797c4d 0f8085cf73
commit f9b92f04c3
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java
View File

@@ -106,8 +106,9 @@ public class RelatedChanges extends TabPanel {
}
private final List<RelatedChangesTab> tabs;
private int maxHeight;
private int maxHeightWithHeader;
private int selectedTab;
private int outstandingCallbacks;
RelatedChanges() {
tabs = new ArrayList<RelatedChangesTab>(Tab.values().length);
@@ -133,7 +134,6 @@ public class RelatedChanges extends TabPanel {
for (Tab tabInfo : Tab.values()) {
RelatedChangesTab panel = new RelatedChangesTab();
panel.setMaxHeight(maxHeight);
add(panel, tabInfo.defaultTitle);
tabs.add(panel);
@@ -205,13 +205,18 @@ public class RelatedChanges extends TabPanel {
}
void setMaxHeight(int height) {
maxHeight = height - (getTabBar().getOffsetHeight() + 2 /* padding */);
for (int i = 0; i < getTabBar().getTabCount(); i++) {
tabs.get(i).setMaxHeight(maxHeight);
maxHeightWithHeader = height;
if (isVisible()) {
applyMaxHeight();
}
}
private int outstandingCallbacks;
private void applyMaxHeight() {
int header = getTabBar().getOffsetHeight() + 2 /* padding */;
for (int i = 0; i < getTabBar().getTabCount(); i++) {
tabs.get(i).setMaxHeight(maxHeightWithHeader - header);
}
}
private abstract class TabCallback<T> implements AsyncCallback<T> {
private final Tab tabInfo;
@@ -253,6 +258,7 @@ public class RelatedChanges extends TabPanel {
if (getTabBar().isTabEnabled(i)) {
selectTab(i);
setVisible(true);
applyMaxHeight();
break;
}
}