diff --git a/java/com/google/gerrit/acceptance/InProcessProtocol.java b/java/com/google/gerrit/acceptance/InProcessProtocol.java index ce2eb4651f..8a46d57502 100644 --- a/java/com/google/gerrit/acceptance/InProcessProtocol.java +++ b/java/com/google/gerrit/acceptance/InProcessProtocol.java @@ -342,7 +342,7 @@ class InProcessProtocol extends TestProtocol { ImmutableList.builder() .add( (pack, commands) -> { - if (affectsSize(pack, commands)) { + if (affectsSize(pack)) { try { quotaBackend .user(identifiedUser) diff --git a/java/com/google/gerrit/server/git/receive/LazyPostReceiveHookChain.java b/java/com/google/gerrit/server/git/receive/LazyPostReceiveHookChain.java index 927d95339d..a19dbac486 100644 --- a/java/com/google/gerrit/server/git/receive/LazyPostReceiveHookChain.java +++ b/java/com/google/gerrit/server/git/receive/LazyPostReceiveHookChain.java @@ -61,7 +61,7 @@ public class LazyPostReceiveHookChain implements PostReceiveHook { @Override public void onPostReceive(ReceivePack rp, Collection commands) { hooks.runEach(h -> h.onPostReceive(rp, commands)); - if (affectsSize(rp, commands)) { + if (affectsSize(rp)) { QuotaResponse.Aggregated a = quotaBackend .user(user) @@ -78,21 +78,7 @@ public class LazyPostReceiveHookChain implements PostReceiveHook { } } - public static boolean affectsSize(ReceivePack rp, Collection commands) { - long packSize; - try { - packSize = rp.getPackSize(); - } catch (IllegalStateException e) { - // No pack was received, i.e. ref deletion or wind back - return false; - } - if (packSize > 0L) { - for (ReceiveCommand cmd : commands) { - if (cmd.getType() != ReceiveCommand.Type.DELETE) { - return true; - } - } - } - return false; + public static boolean affectsSize(ReceivePack rp) { + return rp.hasReceivedPack() && rp.getPackSize() > 0L; } }