opendev/gerrit
Code Issues Proposed changes

Fix some pesky style issues

Browse Source 
Gjslint reports these as errors, which is very annoying. This change
modifies the style only.

Change-Id: I81164534cef6fdfc034f45e347f283916037d974
This commit is contained in:
Kasper Nilsson
2016-09-30 13:56:35 -07:00
parent 1b944dffd8
commit fab595c770
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
View File

@@ -469,18 +469,19 @@ limitations under the License.
});
test('document scrolling calls function to set scroll height', function(done) {
var scrollStub = sinon.stub(element, '_handleScroll',
function() {
assert.isTrue(scrollStub.called);
document.getElementsByTagName('body')[0].style.height = originalHeight+'px';
scrollStub.restore();
done();
});
test('document scrolling calls function to set scroll height',
function(done) {
var scrollStub = sinon.stub(element, '_handleScroll', function() {
assert.isTrue(scrollStub.called);
document.getElementsByTagName('body')[0].style.height =
originalHeight + 'px';
scrollStub.restore();
done();
});
var originalHeight = document.body.scrollHeight;
document.getElementsByTagName('body')[0].style.height = '10000px';
window.scroll(0,100);
window.scroll(0, 100);
});
});
});

2
polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog_test.html
View File

@@ -85,7 +85,7 @@ limitations under the License.
assert.equal(element.message, expected);
});
test('revert a revert', function () {
test('revert a revert', function() {
assert.isNotOk(element.message);
element.populateRevertMessage(
'Revert "one line commit"\n\nChange-Id: abcdefg\n');