opendev/gerrit
Code Issues Proposed changes

Buck: Fix compilation of GWT plugins

Browse Source 
I1f13f4d29 broke compilation of GWT plugins. Also remove unnecessary
dependency of GWT development library.

Change-Id: Ic3ada6a56ddd3b83bfa51d504e525aa52021b6ad
This commit is contained in:
David Ostrovsky
2014-05-19 22:48:33 +02:00
committed by David Ostrovsky
parent 2806f76434
commit fb19356c10
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/BUCK
View File

@@ -29,7 +29,7 @@ gwt_binary(
name = 'ui_opt', name = 'ui_opt',
modules = [MODULE], modules = [MODULE],
module_deps = [':ui_module'], module_deps = [':ui_module'],
deps = DEPS + ['//lib/gwt:dev', ':ui_dbg'], deps = DEPS + [':ui_dbg'],
local_workers = cpu_count(), local_workers = cpu_count(),
strict = True, strict = True,
experimental_args = GWT_COMPILER_ARGS, experimental_args = GWT_COMPILER_ARGS,
@@ -42,7 +42,7 @@ gwt_binary(
style = 'PRETTY', style = 'PRETTY',
optimize = 0, optimize = 0,
module_deps = [':ui_module'], module_deps = [':ui_module'],
deps = DEPS + ['//lib/gwt:dev'], deps = DEPS,
local_workers = cpu_count(), local_workers = cpu_count(),
strict = True, strict = True,
experimental_args = GWT_COMPILER_ARGS, experimental_args = GWT_COMPILER_ARGS,

4
tools/default.defs
View File

@@ -126,12 +126,14 @@ def gerrit_plugin(
gwt_binary( gwt_binary(
name = name + '__gwt_application', name = name + '__gwt_application',
modules = [gwt_module], modules = [gwt_module],
deps = [':%s__plugin' % name] + gwt_deps, deps = gwt_deps,
module_deps = [':%s__plugin' % name],
local_workers = cpu_count(), local_workers = cpu_count(),
strict = True, strict = True,
experimental_args = GWT_COMPILER_ARGS, experimental_args = GWT_COMPILER_ARGS,
vm_args = GWT_JVM_ARGS, vm_args = GWT_JVM_ARGS,
) )
java_binary( java_binary(
name = name, name = name,
manifest_file = genfile('MANIFEST.MF'), manifest_file = genfile('MANIFEST.MF'),