From 5f4587ca75d08d0365ce3bcd54a10553e64700e9 Mon Sep 17 00:00:00 2001 From: Viktar Donich Date: Mon, 12 Feb 2018 16:24:35 -0800 Subject: [PATCH] Tighten specificity of label score regex Bug: Issue 8316 Change-Id: I83014f7ec20f7ea10893440ed13b0d8677d1342a --- .../app/elements/change/gr-message/gr-message.js | 2 +- .../app/elements/change/gr-message/gr-message_test.html | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message.js b/polygerrit-ui/app/elements/change/gr-message/gr-message.js index 6b4499f94a..0e73c6e7a3 100644 --- a/polygerrit-ui/app/elements/change/gr-message/gr-message.js +++ b/polygerrit-ui/app/elements/change/gr-message/gr-message.js @@ -16,7 +16,7 @@ const CI_LABELS = ['Trybot-Ready', 'Tryjob-Request', 'Commit-Queue']; const PATCH_SET_PREFIX_PATTERN = /^Patch Set \d+: /; - const LABEL_TITLE_SCORE_PATTERN = /([A-Za-z0-9-]+)([+-]\d+)/; + const LABEL_TITLE_SCORE_PATTERN = /^([A-Za-z0-9-]+)([+-]\d+)$/; Polymer({ is: 'gr-message', diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message_test.html b/polygerrit-ui/app/elements/change/gr-message/gr-message_test.html index aa18c4e7b6..658dcad58a 100644 --- a/polygerrit-ui/app/elements/change/gr-message/gr-message_test.html +++ b/polygerrit-ui/app/elements/change/gr-message/gr-message_test.html @@ -180,5 +180,14 @@ limitations under the License. }; assert.isOk(Polymer.dom(element.root).querySelector('.positiveVote')); }); + + test('false negative vote', () => { + element.message = { + author: {}, + expanded: false, + message: 'Patch Set 1: Cherry Picked from branch stable-2.14.', + }; + assert.isNotOk(Polymer.dom(element.root).querySelector('.negativeVote')); + }); });