opendev/gerrit
Code Issues Proposed changes

Use DisabledMetricMaker for InMemoryModule and RebuildNotedb

Browse Source 
Most unit test code will not be worrying about metrics so pass in a
dummy implmentation that discards recorded values.

Rebuilding notedb on the command line pgm does not require metrics.
This also applies to other batch programs.

Change-Id: I2703c4e8a3fb9e31587c0ccf6d1f7c4083a4b3fe
This commit is contained in:
Shawn Pearce
2015-11-11 12:48:20 -08:00
parent 4df40f5526
commit fb40adf5b8
3 changed files with 116 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/BatchProgramModule.java
View File

@@ -20,6 +20,8 @@ import com.google.common.cache.Cache;
import com.google.gerrit.extensions.config.FactoryModule;
import com.google.gerrit.extensions.registration.DynamicMap;
import com.google.gerrit.extensions.registration.DynamicSet;
import com.google.gerrit.metrics.DisabledMetricMaker;
import com.google.gerrit.metrics.MetricMaker;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.rules.PrologModule;
import com.google.gerrit.server.CurrentUser;
@@ -89,6 +91,7 @@ public class BatchProgramModule extends FactoryModule {
install(reviewDbModule);
install(new DiffExecutorModule());
install(PatchListCacheImpl.module());
bind(MetricMaker.class).to(DisabledMetricMaker.class);
// Plugins are not loaded and we're just running through each change
// once, so don't worry about cache removal.