opendev/gerrit
Code Issues Proposed changes

Make links appear with the same color in Change UI

Browse Source 
The links to files and the side by side options in the change
screen appear as "non-clickable", while all other links, e.g.
the "All Side-by-Side" and "All Unified", are blue to indicate
a link but the individual file links are black.

This gives the appearance that files are disabled and is not good.

On the other hand, if all links are blue, the colorful links would
distract the user too much.

This patch improves the UI a bit by making links in the Diff column
appear in the same color.

Change-Id: I1f50e0127c227132121b4ff4a7e2f33dd4064a9c
This commit is contained in:
Bruce Zu 2013-09-26 17:16:41 +08:00 committed by David Pursehouse
parent a7a3582291
commit fbbf1d1db1
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java
View File

@ -414,12 +414,19 @@ public class PatchTable extends Composite {
table.setWidget(row, C_PATH, nameCol);
int C_UNIFIED = C_SIDEBYSIDE + 1;
table.setWidget(row, C_SIDEBYSIDE, new PatchLink.SideBySide(
Util.C.patchTableDiffSideBySide(), base, patch.getKey(), row - 1,
detail, PatchTable.this));
table.setWidget(row, C_UNIFIED, new PatchLink.Unified(
Util.C.patchTableDiffUnified(), base, patch.getKey(), row - 1,
detail, PatchTable.this));
PatchLink sideBySide =
new PatchLink.SideBySide(Util.C.patchTableDiffSideBySide(), base,
patch.getKey(), row - 1, detail, PatchTable.this);
sideBySide.setStyleName("gwt-Anchor");
PatchLink unified =
new PatchLink.Unified(Util.C.patchTableDiffUnified(), base,
patch.getKey(), row - 1, detail, PatchTable.this);
unified.setStyleName("gwt-Anchor");
table.setWidget(row, C_SIDEBYSIDE, sideBySide);
table.setWidget(row, C_UNIFIED, unified);
}
void initializeLastRow(int row) {