opendev/gerrit
Code Issues Proposed changes

Use stable links in ProjectDashboardScreen to link to dashboards

Browse Source 
Change-Id: Ic325d3ec417b4a0d55f70d06d2745da6a12b984d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-11-17 07:37:08 +01:00
parent 985da71582
commit fbdee4992e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/dashboards/DashboardsTable.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.client.dashboards;
import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.rpc.NativeList; import com.google.gerrit.client.rpc.NativeList;
import com.google.gerrit.client.ui.NavigationTable; import com.google.gerrit.client.ui.NavigationTable;
import com.google.gerrit.common.PageLinks;
import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.reviewdb.client.Project;
import com.google.gwt.user.client.History; import com.google.gwt.user.client.History;
import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Anchor;
@@ -121,7 +122,8 @@ public class DashboardsTable extends NavigationTable<DashboardInfo> {
final FlexCellFormatter fmt = table.getFlexCellFormatter(); final FlexCellFormatter fmt = table.getFlexCellFormatter();
fmt.getElement(row, 1).setTitle(Util.C.dashboardDefaultToolTip()); fmt.getElement(row, 1).setTitle(Util.C.dashboardDefaultToolTip());
} }
table.setWidget(row, 2, new Anchor(k.path(), "#" + k.url())); table.setWidget(row, 2, new Anchor(k.path(), "#"
+ PageLinks.toProjectDashboard(new Project.NameKey(k.project()), k.id())));
table.setText(row, 3, k.description()); table.setText(row, 3, k.description());
if (k.project() != null && !project.get().equals(k.project())) { if (k.project() != null && !project.get().equals(k.project())) {
table.setText(row, 4, k.project()); table.setText(row, 4, k.project());