opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-3.1' into stable-3.2

Browse Source 
* stable-3.1:
  Error Prone: Enable and fix ClassCanBeStatic
  AutoRegisterModulesTest: Declare inner classes as static
  Fix issue with auto registering ssh commands
  Convert plugin's name to lowercase when generate hook name
  Update git submodules
  Update git submodules
  ErrorProne: Increase severity of FunctionalInterfaceClash to ERROR
  Revert "LifecycleListener: Mark stop method as default to make it optional"
  Update git submodules
  LifecycleListener: Mark stop method as default to make it optional

Change-Id: Iaa7655a5cc33970f4925e94c98bfa7be5e01a346
This commit is contained in:
David Pursehouse
2020-06-25 09:51:19 +09:00
parent 771aceedbf b38da23bfb
commit fbe441bafb
5 changed files with 110 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/elements/plugins/gr-dom-hooks/gr-dom-hooks.js
View File

@@ -36,7 +36,12 @@ GrDomHooksManager.prototype._getHookName = function(endpointName,
if (opt_moduleName) {
return endpointName + ' ' + opt_moduleName;
} else {
return this._plugin.getPluginName() + '-autogenerated-' + endpointName;
// lowercase in case plugin's name contains uppercase letters
// TODO: this still can not prevent if plugin has invalid char
// other than uppercase, but is the first step
// https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name
const pluginName = this._plugin.getPluginName() || 'unknown_plugin';
return pluginName.toLowerCase() + '-autogenerated-' + endpointName;
}
};