opendev/gerrit
Code Issues Proposed changes

SetEditPreferences: Return info from REST handler

Browse Source 
This is needed to harmonize the API across different user preferences:

* diff
* edit
* general

Change-Id: I8126fc217a442c551fba1fcfcecdb6c07d1b2d64
This commit is contained in:
David Ostrovsky
2016-04-04 21:59:13 +02:00
parent eed48f56ee
commit fc833989b6
6 changed files with 40 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java
View File

@@ -15,11 +15,11 @@
package com.google.gerrit.client.editor;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.VoidResult;
import com.google.gerrit.client.account.AccountApi;
import com.google.gerrit.client.account.EditPreferences;
import com.google.gerrit.client.rpc.GerritCallback;
import com.google.gerrit.client.ui.NpIntTextBox;
import com.google.gerrit.extensions.client.EditPreferencesInfo;
import com.google.gerrit.extensions.client.KeyMapType;
import com.google.gerrit.extensions.client.Theme;
import com.google.gwt.core.client.GWT;
@@ -235,12 +235,13 @@ public class EditPreferencesBox extends Composite {
@UiHandler("save")
void onSave(@SuppressWarnings("unused") ClickEvent e) {
AccountApi.putEditPreferences(prefs, new GerritCallback<VoidResult>() {
@Override
public void onSuccess(VoidResult n) {
prefs.copyTo(Gerrit.getEditPreferences());
}
});
AccountApi.putEditPreferences(prefs,
new GerritCallback<EditPreferences>() {
@Override
public void onSuccess(EditPreferences p) {
Gerrit.setEditPreferences(p.copyTo(new EditPreferencesInfo()));
}
});
close();
}