opendev/gerrit
Code Issues Proposed changes

Add 'del' as alias for 'delete' in JavaScript API

Browse Source 
'delete' is a keyword in JavaScript and can't be easily used as
function name. E.g. invoking the Gerrit.delete function from RestApi by
  '$wnd.Gerrit.delete'(p, r)
fails on execution with
   "$wnd.Gerrit.delete" is not a function

Because of this at the moment plugins can't do delete calls via the
RestApi class.

Trying to write "'$wnd.Gerrit.delete'(p, r)" as
  $wnd.Gerrit.delete(p, r)
or
  $wnd.Gerrit.'delete'(p, r)
fails already during compilation.

Adding 'del' as an alias allows use to simply invoke
  $wnd.Gerrit.del(p, r)

Change-Id: Idced35f0e27d4a932a7e8d48b0e2b19187bb427c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2014-02-03 17:51:20 +01:00
parent f484d7eb91
commit fc998c4ccf
5 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/rpc/RestApi.java
View File

@@ -160,7 +160,7 @@ public class RestApi {
}
private native static void delete(String p, JavaScriptObject r)
/*-{ '$wnd.Gerrit.delete'(p, r) }-*/;
/*-{ $wnd.Gerrit.del(p, r) }-*/;
private native static <T extends JavaScriptObject>
JavaScriptObject wrap(AsyncCallback<T> b) /*-{