opendev/gerrit
Code Issues Proposed changes

Revert "restapi: add an alternative CreateChange endpoint"

Browse Source 
This reverts commit 44c724e185.

Reason for revert: this did not fix our slowness problem, which
was slow CreateChange calls on Android's platform/frameworks/base
when specifying a merge. On closer inspection, generating the merge
reads too much data.

Change-Id: I9fb9a074bc7ae9da13ef262a5a9a7a2596ec0387
This commit is contained in:
Han-Wen Nienhuys
2019-10-30 17:15:39 +00:00
committed by David Pursehouse
parent e2be01cde7
commit fccb35cf19
6 changed files with 8 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
Documentation/rest-api-projects.txt
View File

@@ -1252,57 +1252,6 @@ entity is returned.
}
----
[[create-change]]
=== Create Change for review.
This endpoint is functionally equivalent to
link:rest-api-changes.html#create-change[create change in the change
API], but it has the project name in the URL, which is easier to route
in sharded deployments.
.Request
----
POST /projects/myProject/create.change HTTP/1.0
Content-Type: application/json; charset=UTF-8
{
"subject" : "Let's support 100% Gerrit workflow direct in browser",
"branch" : "master",
"topic" : "create-change-in-browser",
"status" : "NEW"
}
----
As response a link:#change-info[ChangeInfo] entity is returned that describes
the resulting change.
.Response
----
HTTP/1.1 201 OK
Content-Disposition: attachment
Content-Type: application/json; charset=UTF-8
)]}'
{
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941",
"project": "myProject",
"branch": "master",
"topic": "create-change-in-browser",
"change_id": "I8473b95934b5732ac55d26311a706c9c2bde9941",
"subject": "Let's support 100% Gerrit workflow direct in browser",
"status": "NEW",
"created": "2014-05-05 07:15:44.639000000",
"updated": "2014-05-05 07:15:44.639000000",
"mergeable": true,
"insertions": 0,
"deletions": 0,
"_number": 4711,
"owner": {
"name": "John Doe"
}
}
----
[[create-access-change]]
=== Create Access Rights Change for review.
--