opendev/gerrit
Code Issues Proposed changes

Allow admins to disable remote plugin installation

Browse Source 
Some systems might prefer to block remote plugin installation,
requiring the user to instead have access to the server's own
$site_path/plugins directory before code can be injected into
the installation.

Change-Id: I16bd9de83e022a15767fd29ce9e2fb55674f103b
This commit is contained in:
Shawn Pearce
2014-02-14 16:42:35 -08:00
committed by Edwin Kempin
parent a145270984
commit fd03350b9e
9 changed files with 70 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginsCollection.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.server.plugins;
import com.google.gerrit.extensions.registration.DynamicMap;
import com.google.gerrit.extensions.restapi.AcceptsCreate;
import com.google.gerrit.extensions.restapi.IdString;
import com.google.gerrit.extensions.restapi.MethodNotAllowedException;
import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
import com.google.gerrit.extensions.restapi.RestCollection;
import com.google.gerrit.extensions.restapi.RestView;
@@ -58,7 +59,10 @@ public class PluginsCollection implements
@SuppressWarnings("unchecked")
@Override
public InstallPlugin create(TopLevelResource parent, IdString id)
throws ResourceNotFoundException {
throws ResourceNotFoundException, MethodNotAllowedException {
if (!loader.isRemoteAdminEnabled()) {
throw new MethodNotAllowedException("remote installation is disabled");
}
return new InstallPlugin(loader, id.get(), true /* created */);
}