opendev/gerrit
Code Issues Proposed changes

Remove more finals from method signatures

Browse Source 
Change-Id: I5849ebf378469dcfd5b89bed88c6f7dedf67f7ba
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-06-14 09:38:58 +02:00
parent 0cca74b78a
commit fd8fa32db1
27 changed files with 63 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java
View File

@@ -99,12 +99,12 @@ class OpenIdServiceImpl {
@Inject
OpenIdServiceImpl(
final DynamicItem<WebSession> cf,
final Provider<IdentifiedUser> iu,
DynamicItem<WebSession> cf,
Provider<IdentifiedUser> iu,
CanonicalWebUrl up,
@GerritServerConfig final Config config,
final AuthConfig ac,
final AccountManager am,
@GerritServerConfig Config config,
AuthConfig ac,
AccountManager am,
ProxyProperties proxyProperties) {
if (proxyProperties.getProxyUrl() != null) {
@@ -139,9 +139,9 @@ class OpenIdServiceImpl {
DiscoveryResult discover(
HttpServletRequest req,
String openidIdentifier,
final SignInMode mode,
final boolean remember,
final String returnToken) {
SignInMode mode,
boolean remember,
String returnToken) {
final State state;
state = init(req, openidIdentifier, mode, remember, returnToken);
if (state == null) {