opendev/gerrit
Code Issues Proposed changes

Make the parent project names in the ProjectDashboardScreen links

Browse Source 
The parent project names for the inherited dashboards are now links to
the ProjectDashboardScreen of the parent project.

Change-Id: I2793a40c1e625e2f2e1e5412228cc3855e65263e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-11-17 04:43:36 +01:00
parent 0fa73cd4b9
commit fea85f8214
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-common/src/main/java/com/google/gerrit/common/PageLinks.java
View File

@@ -67,6 +67,10 @@ public class PageLinks {
return toChangeQuery(op("owner", fullname) + " " + status(status), TOP); return toChangeQuery(op("owner", fullname) + " " + status(status), TOP);
} }
public static String toProjectDashboards(Project.NameKey proj) {
return ADMIN_PROJECTS + proj.get() + ",dashboards";
}
public static String toChangeQuery(final String query) { public static String toChangeQuery(final String query) {
return toChangeQuery(query, TOP); return toChangeQuery(query, TOP);
} }

5
gerrit-gwtui/src/main/java/com/google/gerrit/client/dashboards/DashboardsTable.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.client.dashboards;
import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.rpc.NativeList; import com.google.gerrit.client.rpc.NativeList;
import com.google.gerrit.client.ui.NavigationTable; import com.google.gerrit.client.ui.NavigationTable;
import com.google.gerrit.common.PageLinks;
import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.reviewdb.client.Project;
import com.google.gwt.user.client.History; import com.google.gwt.user.client.History;
import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Anchor;
@@ -124,7 +125,9 @@ public class DashboardsTable extends NavigationTable<DashboardInfo> {
table.setWidget(row, 2, new Anchor(k.path(), "#" + k.url())); table.setWidget(row, 2, new Anchor(k.path(), "#" + k.url()));
table.setText(row, 3, k.description()); table.setText(row, 3, k.description());
if (k.project() != null && !project.get().equals(k.project())) { if (k.project() != null && !project.get().equals(k.project())) {
table.setText(row, 4, k.project()); table.setWidget(row, 4, new Anchor(k.project(), "#"
+ PageLinks.toProjectDashboards(new Project.NameKey(k
.project()))));
} }
setRowItem(row, k); setRowItem(row, k);
} }