opendev/gerrit
Code Issues Proposed changes

Merge "Include summary of file comments in review message"

Browse Source
This commit is contained in:
David Pursehouse
2012-11-29 00:53:39 -08:00
committed by Gerrit Code Review
parent 375f8a818c aae26d0e14
commit feb68ebdbb
1 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java
View File

@@ -455,11 +455,38 @@ public class PostReview implements RestModifyView<RevisionResource, Input> {
for (String d : labelDelta) { for (String d : labelDelta) {
buf.append(" ").append(d); buf.append(" ").append(d);
} }
if (comments.size() == 1) {
buf.append("\n\n(1 inline comment)"); if (comments.size() >= 1) {
} else if (comments.size() > 1) { int inlineCommentCount = 0;
buf.append(String.format("\n\n(%d inline comments)", comments.size())); int fileCommentsCount = 0;
for (PatchLineComment c : comments) {
if (c.getLine() == 0) {
fileCommentsCount++;
} else {
inlineCommentCount++;
} }
}
buf.append("\n\n(");
if (fileCommentsCount != 0) {
if (fileCommentsCount == 1) {
buf.append("1 file comment");
} else {
buf.append(String.format("%d file comments", fileCommentsCount));
}
}
if (inlineCommentCount != 0) {
if (fileCommentsCount != 0) {
buf.append(", ");
}
if (inlineCommentCount == 1) {
buf.append("1 inline comment");
} else {
buf.append(String.format("%d inline comments", inlineCommentCount));
}
}
buf.append(")");
}
if (!msg.isEmpty()) { if (!msg.isEmpty()) {
buf.append("\n\n").append(msg); buf.append("\n\n").append(msg);
} }