opendev/gerrit
Code Issues Proposed changes

Clean-up of formatDate method in SshLogLayout

Browse Source 
Change-Id: Idf321a7f91354f6e232e2cc4f945e74156902713
This commit is contained in:
Eryk Szymanski 2013-11-21 16:52:45 +01:00
parent f9cd1b5a63
commit feebf7cc98
1 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshLogLayout.java
View File

@ -23,7 +23,6 @@ import java.util.Calendar;
import java.util.Date; import java.util.Date;
import java.util.TimeZone; import java.util.TimeZone;
public final class SshLogLayout extends Layout { public final class SshLogLayout extends Layout {
private static final String P_SESSION = "session"; private static final String P_SESSION = "session";
@ -78,31 +77,18 @@ public final class SshLogLayout extends Layout {
if (rounded != lastTimeMillis) { if (rounded != lastTimeMillis) {
synchronized (calendar) { synchronized (calendar) {
final int start = sbuf.length(); final int start = sbuf.length();
calendar.setTimeInMillis(rounded); calendar.setTimeInMillis(rounded);
sbuf.append(calendar.get(Calendar.YEAR)); sbuf.append(calendar.get(Calendar.YEAR));
sbuf.append('-'); sbuf.append('-');
final int month = calendar.get(Calendar.MONTH) + 1; sbuf.append(toTwoDigits(calendar.get(Calendar.MONTH) + 1));
if (month < 10) sbuf.append('0');
sbuf.append(month);
sbuf.append('-'); sbuf.append('-');
final int day = calendar.get(Calendar.DAY_OF_MONTH); sbuf.append(toTwoDigits(calendar.get(Calendar.DAY_OF_MONTH)));
if (day < 10) sbuf.append('0');
sbuf.append(day);
sbuf.append(' '); sbuf.append(' ');
final int hour = calendar.get(Calendar.HOUR_OF_DAY); sbuf.append(toTwoDigits(calendar.get(Calendar.HOUR_OF_DAY)));
if (hour < 10) sbuf.append('0');
sbuf.append(hour);
sbuf.append(':'); sbuf.append(':');
final int mins = calendar.get(Calendar.MINUTE); sbuf.append(toTwoDigits(calendar.get(Calendar.MINUTE)));
if (mins < 10) sbuf.append('0');
sbuf.append(mins);
sbuf.append(':'); sbuf.append(':');
final int secs = calendar.get(Calendar.SECOND); sbuf.append(toTwoDigits(calendar.get(Calendar.SECOND)));
if (secs < 10) sbuf.append('0');
sbuf.append(secs);
sbuf.append(','); sbuf.append(',');
sbuf.getChars(start, sbuf.length(), lastTimeString, 0); sbuf.getChars(start, sbuf.length(), lastTimeString, 0);
lastTimeMillis = rounded; lastTimeMillis = rounded;
@ -110,13 +96,11 @@ public final class SshLogLayout extends Layout {
} else { } else {
sbuf.append(lastTimeString); sbuf.append(lastTimeString);
} }
if (millis < 100) { sbuf.append(String.format("%03d", millis));
sbuf.append('0'); }
}
if (millis < 10) { private String toTwoDigits(int input) {
sbuf.append('0'); return String.format("%02d", input);
}
sbuf.append(millis);
} }
private void req(String key, StringBuffer buf, LoggingEvent event) { private void req(String key, StringBuffer buf, LoggingEvent event) {