From fef096c00dcf3f6263801f63dd9d760b79cd2f03 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Mon, 16 Feb 2009 09:52:28 -0800 Subject: [PATCH] Fix detach assertion error caused by loading messing being removed Apparently when we delete a RootPanel's DOM element from the host page we also must call detachNow() to remove it from the cleanup list within GWT, otherwise the onUnload handler for the page has an assertion error in hosted mode. Signed-off-by: Shawn O. Pearce --- src/main/java/com/google/gerrit/client/Gerrit.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/google/gerrit/client/Gerrit.java b/src/main/java/com/google/gerrit/client/Gerrit.java index db8b8fd1d0..5e709d9539 100644 --- a/src/main/java/com/google/gerrit/client/Gerrit.java +++ b/src/main/java/com/google/gerrit/client/Gerrit.java @@ -280,6 +280,7 @@ public class Gerrit implements EntryPoint { private void showInitialScreen() { final RootPanel sg = RootPanel.get("gerrit_startinggerrit"); sg.getElement().getParentElement().removeChild(sg.getElement()); + RootPanel.detachNow(sg); History.addHistoryListener(new Link()); if ("".equals(History.getToken())) {