diff --git a/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java b/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java index 5f6b088deb..78687cde2a 100644 --- a/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java +++ b/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java @@ -20,6 +20,7 @@ import static java.util.stream.Collectors.toList; import com.google.common.base.Strings; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; +import com.google.gerrit.common.Nullable; import com.google.gerrit.common.data.LabelType; import com.google.gerrit.extensions.registration.DynamicMap; import com.google.gerrit.index.query.Predicate; @@ -100,7 +101,7 @@ public class ReviewerRecommender { } public List suggestReviewers( - ChangeNotes changeNotes, + @Nullable ChangeNotes changeNotes, SuggestReviewers suggestReviewers, ProjectState projectState, List candidateList) diff --git a/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java b/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java index ac88b65449..95557b5444 100644 --- a/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java +++ b/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java @@ -21,6 +21,7 @@ import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; +import com.google.gerrit.common.Nullable; import com.google.gerrit.common.data.GroupReference; import com.google.gerrit.extensions.common.GroupBaseInfo; import com.google.gerrit.extensions.common.SuggestedReviewerInfo; @@ -161,17 +162,25 @@ public class ReviewersUtil { } public List suggestReviewers( - ChangeNotes changeNotes, + @Nullable ChangeNotes changeNotes, SuggestReviewers suggestReviewers, ProjectState projectState, VisibilityControl visibilityControl, boolean excludeGroups) throws IOException, OrmException, ConfigInvalidException, PermissionBackendException { CurrentUser currentUser = self.get(); - log.debug( - "Suggesting reviewers for change {} to user {}.", - changeNotes.getChangeId().get(), - currentUser.getLoggableName()); + if (changeNotes != null) { + log.debug( + "Suggesting reviewers for change {} to user {}.", + changeNotes.getChangeId().get(), + currentUser.getLoggableName()); + } else { + log.debug( + "Suggesting default reviewers for project {} to user {}.", + projectState.getName(), + currentUser.getLoggableName()); + } + String query = suggestReviewers.getQuery(); log.debug("Query: {}", query); int limit = suggestReviewers.getLimit(); @@ -272,7 +281,7 @@ public class ReviewersUtil { } private List recommendAccounts( - ChangeNotes changeNotes, + @Nullable ChangeNotes changeNotes, SuggestReviewers suggestReviewers, ProjectState projectState, List candidateList)