Idc0c29374 reverted the submodule reference to plugins/replication
for no apparent reason. Because of this, the submodule is always
reported as dirty by Git.
Change-Id: Ic511f3c165cec5cb41dcebb899f9c27a2eeb4dd0
* Update plugins/delete-project from branch 'master'
to 39dd25c822be14a69282d38e5205f0ca4f2902c1
- Merge branch 'stable-3.1'
* stable-3.1:
Fix so that GWTUI js file is not executed under PolyGerrit
DeleteProjectIT: Check that project gets unwatched after deletion
DeleteProjectIT: Assert that after forced delete reindexing happened
DeleteProjectIT: Add ssh delete watched project test similar to http
Fix reindex after project deletion
Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
build.md: Correct in-tree test command
Replace bazel-genfiles with bazel-bin in documentation
Change-Id: I68db79e2797b254c7fd79d8587b51e066f81b7f4
- Merge branch 'stable-3.0' into stable-3.1
* stable-3.0:
Fix so that GWTUI js file is not executed under PolyGerrit
DeleteProjectIT: Check that project gets unwatched after deletion
DeleteProjectIT: Assert that after forced delete reindexing happened
DeleteProjectIT: Add ssh delete watched project test similar to http
Fix reindex after project deletion
Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
build.md: Correct in-tree test command
Replace bazel-genfiles with bazel-bin in documentation
Adjust DeleteProjectIT and DatabaseDeleteHandler to API changes.
Change-Id: I7dd082b728fa7a98b225c10ef6d2ecf11e7daa09
- Merge branch 'stable-2.16' into stable-3.0
* stable-2.16:
Fix so that GWTUI js file is not executed under PolyGerrit
Change-Id: I9b5e59bb31cc7de07cf863af7baebe556e8f494f
- Merge "Fix so that GWTUI js file is not executed under PolyGerrit" into stable-2.16
- Merge branch 'stable-2.16' into stable-3.0
* stable-2.16:
DeleteProjectIT: Check that project gets unwatched after deletion
DeleteProjectIT: Assert that after forced delete reindexing happened
DeleteProjectIT: Add ssh delete watched project test similar to http
Fix reindex after project deletion
Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
build.md: Correct in-tree test command
Replace bazel-genfiles with bazel-bin in documentation
Change-Id: Ic060483ccb190c7f31c3bb13eeb15d230c3378b1
- Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
DeleteProjectIT: Check that project gets unwatched after deletion
DeleteProjectIT: Assert that after forced delete reindexing happened
DeleteProjectIT: Add ssh delete watched project test similar to http
Fix reindex after project deletion
Change-Id: I29fca09892a5a6878547c5d0bbd2966310d986a3
- Merge changes Iaf1826ab,I02632cb6,I5ca2ec2b,I6578e664 into stable-2.15
* changes:
DeleteProjectIT: Check that project gets unwatched after deletion
DeleteProjectIT: Assert that after forced delete reindexing happened
DeleteProjectIT: Add ssh delete watched project test similar to http
Fix reindex after project deletion
- Fix so that GWTUI js file is not executed under PolyGerrit
When using PolyGerrit, it appears that it loads GWTUI specific
delete-project js files. It dosen't appear to inject "window.Polymer"
into it thus will always equal undefined or false.
To fix this we look for the GERRIT_UI cookie which if the user is using
GWTUI, will have this set.
Change-Id: I2512fe18108799f3a73b00ada8a756eb6e397879
- DeleteProjectIT: Check that project gets unwatched after deletion
Change-Id: Iaf1826ab98280aa042304b30d873575c71bdac60
- DeleteProjectIT: Assert that after forced delete reindexing happened
Unit tests didn't check whether reindexing happened after deletion or
not. In NoteDb case even after git repo got deleted changes were still
present in the index, so querying on a deleted project name returned
change information.
Bug: Issue 11650
Change-Id: I02632cb6195e262478850e5ec589d01aab4a9ef3
- DeleteProjectIT: Add ssh delete watched project test similar to http
Change-Id: I5ca2ec2b7df92a8fc24135c4d94efe00ab4d761e
- Fix reindex after project deletion
Make plugin to properly support NoteDb.
DatabaseDeleteHandler:
- Check if ReviewDb is enabled from inside DatabaseHandler.
- Add functionality for deleteChanges to check whether ReviewDb is
enabled, since NoteDb behaves differently compared to ReviewDb.
Bug: Issue 11650
Change-Id: I6578e6649e9fe0d8c139243cdade8c86e1b6c0ed
- Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Change-Id: Ib378315a93969b1de605e2d9cc8b2758f37920e4
- Upgrade bazlets to latest stable-2.16
download_file.py: Fix root workspace directory detection
Change-Id: I26017fc180b761feba2b5f01d4eb7a0e7c7b690c
- Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bazel: Migrate workspace status script to python
Change-Id: Ib8b9c5efc04f2b2f983c091bf96c4eafeca510ec
- Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Change-Id: Icf85a0b3340f2bfe58b3b21ec57a2640cf8a1ba4
- Merge branch 'stable-2.14' into stable-2.15
* stable-2.14:
Upgrade bazlets to latest stable-2.14
Bazel: Migrate workspace status script to python
Change-Id: I9ff2983f304b3cfa04ef88401f09d33c5746595f
- Upgrade bazlets to latest stable-2.15
download_file.py: Fix root workspace directory detection
Change-Id: I1c5eb23dfe5978270c10ef6d2baaed7ecd0a04fc
- Upgrade bazlets to latest stable-2.14
download_file.py: Fix root workspace directory detection
Change-Id: Id2da57a98ab0344dc9942d9ff0338309494b0f48
- Bazel: Migrate workspace status script to python
Migrate tools/workspace-status.sh script to Python to ensure better
compatibility with other operating systems, as suggested in: [1].
[1] https://github.com/bazelbuild/bazel/issues/5958
Change-Id: I20ec325d610353309a40fc85132382004bc61bd0
- Upgrade bazlets to latest stable-2.16
Fix genrule2 to clean up temporary folder content
Change-Id: I1d186a2082b364f7acc2d99c20ec0211efebbfd2
- Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
Change-Id: Ie6b12736c2b07752cf91908764bf828a83694c6c
- Upgrade bazlets to latest stable-2.15
Fix genrule2 to clean up temporary folder content
Change-Id: I1d186a2082b364f7acc2d99c20ec0211efebbfd2
- Merge branch 'stable-2.14' into stable-2.15
* stable-2.14:
Upgrade bazlets to latest stable-2.14
Change-Id: I53bd20467b8c6268a102acc75badcaf7290ce720
- Upgrade bazlets to latest stable-2.14
Fix genrule2 to clean up temporary folder content
Change-Id: I1d186a2082b364f7acc2d99c20ec0211efebbfd2
- Merge branch 'stable-2.14' into stable-2.15
* stable-2.14:
Bump Bazel version to 1.1.0
Change-Id: Ia7d244ec3ec3ae0078cb8b766bef95b3c9be922a
- Bump Bazel version to 1.1.0
Change-Id: I4e4c2a3c6f1b73e913fd6eda7e53f30fd8a20985
- Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
build.md: Correct in-tree test command
Change-Id: Iea24800c7100e6c0ab405158a3573eceb0f3957e
- build.md: Correct in-tree test command
Change-Id: Iff17be4a87b058eeabc30faf774c04e26f9d51ea
- Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
Replace bazel-genfiles with bazel-bin in documentation
Change-Id: I1496826af979861ef9391d113430379535a152e4
- Merge branch 'stable-2.14' into stable-2.15
* stable-2.14:
Replace bazel-genfiles with bazel-bin in documentation
Change-Id: I70ea61357ec662fa2e18325a437185d27bcd4f3d
- Replace bazel-genfiles with bazel-bin in documentation
Bug: Issue 11757
Change-Id: I0c901f84e0c4c07a4ae913eab4f71e1f6167dab5
* Update plugins/hooks from branch 'master'
to 6316be2828808dafc546ecd11c055396d0b4951b
- Merge branch 'stable-3.1'
* stable-3.1:
Fix and clarify documentation of ref-update and commit-received hooks
Correct documentation of ref-update hook regarding output
Change-Id: I0926e8a9ab58be09ba7c30b3834ddf86b483480f
- Merge branch 'stable-3.0' into stable-3.1
* stable-3.0:
Fix and clarify documentation of ref-update and commit-received hooks
Correct documentation of ref-update hook regarding output
Change-Id: Ifa4fefac518fc170f3248ebfcbe5e1a338e46c0f
- Merge branch 'stable-2.16' into stable-3.0
* stable-2.16:
Fix and clarify documentation of ref-update and commit-received hooks
Correct documentation of ref-update hook regarding output
Change-Id: Ia446c95e1f6ca12e1cbd198d3a7e4f6a16b09fc6
- Fix and clarify documentation of ref-update and commit-received hooks
- Clarify behavior of ref-update when multiple commits are pushed, i.e.
that it is only called once for the entire ref update.
- Fix the documentation of commit-received which states that it is called
for changes pushed for review. In fact it is also called for direct
pushes, but unlike ref-update it is called once for each commit.
Change-Id: Ie3e2dcab37eeb5d0ed06e05322e72d3fc73925fd
- Correct documentation of ref-update hook regarding output
The output of the hook is only returned when the update is rejected,
not regardless of the return code as stated in the doc.
Change-Id: I93483f44e31e7055c302c0758084de868d1c4f93
* Update plugins/codemirror-editor from branch 'master'
to 9508693bd0a85560674143256314beac08f2d8ca
- Replace 'Menlo' with 'SF Mono'
'Menlo' was replaced by 'SF Mono' from Mac OS 10.11,
And Menlo is not rendering symbols and characters correctly.
See also https://gerrit-review.googlesource.com/c/gerrit/+/246513
Change-Id: Iff8c94d5d77d7388f32bb62d67438e5e97f2ab80
This makes the annotation usable even in cases where we don't want
to link the entire acceptance framework. For example: Query tests.
Change-Id: I5050091e2792472b0312f50ae4572ca6e6c0abf9
Rather than passing in the change Id, which is a breaking API change,
let the implementation get the change Id from the patch set Id.
This reverts commit 593a5007052c340920d5715e62b4eeec617a6f54.
Bug: Issue 11905
Change-Id: Ieba95cadcf7a4f60664120c59916ebce4a1caca4
* stable-3.1:
Fix JSDoc comments for behaviors
Use attribute binding for data-... attributes
Fix missing HTML links
Avoid browser caching for diff on edit patch
MergeValidationListener: Include the change Id in onPreMerge
Upgrade jackson-core to 2.10.1
Add border between robot comment and action buttons
Change-Id: Ifdded7a4f552ea3222e178d15adc2f4febcde177
* stable-3.0:
Avoid browser caching for diff on edit patch
MergeValidationListener: Include the change Id in onPreMerge
Upgrade jackson-core to 2.10.1
Change-Id: Ie35736b6dcfd4f85c96f87d705e1257ea801a355
* stable-2.16:
Avoid browser caching for diff on edit patch
MergeValidationListener: Include the change Id in onPreMerge
Upgrade jackson-core to 2.10.1
Change-Id: I1eb449cda2fa0d95029271f29a7b5c0e161edb97
* Update plugins/replication from branch 'stable-3.1'
to 51750cae8ba3c68bcefedbe8b05faabf9ea5ada4
- Create persistent task files safely
Use a temporary directory to create the files in first to avoid
partially written files being exposed in the waiting directory.
Change-Id: I82222e16b52926ced304cb24eadd1c8d56cf9a7a
- Fix potential loss of persisted replication task
There was a race window between the check to see if any new updates were
available for the completed update and the deletion of the persistent
update. If an update occurred in that window it could leave the event
missing from the persisted task store. If the server went down before
this update completed, the update would be missed entirely.
Eliminate the race by separating the running tasks from the waiting
tasks in the persistent store by placing each into their own
subdirectories. Place new waiting tasks in a "waiting" directory and
move them to the "running" directory once they are running. This allows
new updates to be persisted to the "waiting" directory while a similar
update is running without the waiting task getting deleted when the
persisted running task is deleted. On startup, reset all running tasks
by moving them back to the waiting directory to ensure that they are
retried.
Reset "running" tasks (return them to the "waiting" directory) when a
retry is rescheduled, this allows the retry to be consolidated with the
new run, and helps ensure that the persistence store reflects what is
actually happening better.
Bug: Issue 11672
Change-Id: Ia31329e8d939f8e5cb1e7455de69744431f34d66
* Update plugins/replication from branch 'master'
to d7c09fbb4c18b1743d6060d361171c2a5237f22b
- Merge branch 'stable-3.0'
* stable-3.0:
Clarify that starred-changes ref is not needed on slaves
Change-Id: I4248889146c31d8f956dd0b3ff7a3c4881b97773
- Merge branch 'stable-2.16' into stable-3.0
* stable-2.16:
Clarify that starred-changes ref is not needed on slaves
Change-Id: Id58a2c1038df9a576312a732ffe2429b7382a5d5
- Clarify that starred-changes ref is not needed on slaves
When using the replication plugin to push to a Gerrit slave
or to a standard Git repository, refs/starred-changes/* is not
needed in the replication.config.
Change-Id: Ia77da5a0a8b0247470507bf28680117801c441d3
* stable-2.16:
Set version to 2.16.14-SNAPSHOT
Set version to 2.16.13
Update git submodules
Init: handle multiple httpd.listenUrl entries
Change-Id: I635edd2cfeb18f51e404ff5a6c716a55724493bf
* Update plugins/plugin-manager from branch 'master'
to d486f1edac54c63c46f92c93fa15958f89cfe60f
- Merge branch 'stable-2.16'
* stable-2.16:
Set next version to 3.1
Change-Id: I71973fc0b2e2764997f7007beabb2d257ca3f6eb
- Set next version to 3.1
Next forthcoming Gerrit version is 3.1 and thus the plugin-manager
should return master plugins when the version string starts with
3.1 *ONLY*.
Bug: Issue 11880
Change-Id: I49e193c75d2937b2ddb8dd67c1d84bf8b4e52bb9
* Update plugins/replication from branch 'stable-2.16'
to 22ef9a9634008dfc09ea4dae6f17d99aa4dbbb81
- Clarify that starred-changes ref is not needed on slaves
When using the replication plugin to push to a Gerrit slave
or to a standard Git repository, refs/starred-changes/* is not
needed in the replication.config.
Change-Id: Ia77da5a0a8b0247470507bf28680117801c441d3
* Update plugins/replication from branch 'master'
to 4786c07027a0040810ae3e6a517f737cb57e1283
- Prune non-waiting tasks from queue during distribution
Make the replication distributor also prune the tasks which have been
removed from the persistent waiting directory but that are still in the
queue. Since these tasks are not in the waiting directory, they will not
run once they could run anyway. Cleaning these tasks up gives a more
accurate picture of the replication work still needing to be done.
Presumably these tasks have been removed externally by another actor
(likely because they completed on another master in the cluster). This
keeps the scheduled and waiting lists approximately synchronized across
all the nodes in a multi-master cluster.
Change-Id: If99ed75041fa07632fdc0f23473dad4d8942a3e1
- Add a replication distributor
The distributor schedules everything from the persistent waiting list
every replication.distributionInterval so that replication can act on
externally written tasks (likely by other nodes in the cluster). The
interval defaults to 0, off.
Change-Id: I8d7799b3a6f3f5362561fc593e52628ec2de51d4
Changes the normal font-size from 13px to 14px.
Enforces 24px row height in change metadata and change requirements for
most rows. Text spans should always be 20px in height, even for icons
inputs and gr-autocomplete. Metadata titles are not bold anymore.
Converts the --line-height-* css vars from being relative to absolute.
That is extremely useful for specifying height of icons in inline layout
flow.
Reduces tab height (Files, Checks, Change Log, etc.) to 36px.
Dashboard, file list and change log rows are all targeted to have 28px
height: 20px line-height + 2*4px padding. For the change log this seems
too drastic a change, so we are keeping 36px height for now.
Reduces the vertical padding in the diff-view header.
Makes the comment thread widget nicer by replacing the border with
margin, box-shadow and border-radius. Colors the buttons blue and
reduces them to the 20px line height. Change the border color from
black to gray.
Change-Id: I3fc76c64dc42b61f05cbeb8e3a62629240571080
* Update plugins/replication from branch 'master'
to 5622267e9fe339e185c6e80978b57100476d8f25
- Remove unused private methods
Change-Id: Ibad18b68f471bfb2e6fadaf1455993aa2d382d9d
- Get a URI lock before running tasks.
This allows more than one related gerrit process (as in multi-master
situations) to access the persistent task store at the same time without
deleting each other's task files. This also prevents more than one gerrit
process from pushing to the same URI at the same time.
Change-Id: I1f3f4d60605ff21038e722553cb38494e18b9ff9
- Create persistent task files safely
Use a temporary directory to create the files in first to avoid
partially written files being exposed in the waiting directory.
Change-Id: I82222e16b52926ced304cb24eadd1c8d56cf9a7a
- Fix potential loss of persisted replication task
There was a race window between the check to see if any new updates were
available for the completed update and the deletion of the persistent
update. If an update occurred in that window it could leave the event
missing from the persisted task store. If the server went down before
this update completed, the update would be missed entirely.
Eliminate the race by separating the running tasks from the waiting
tasks in the persistent store by placing each into their own
subdirectories. Place new waiting tasks in a "waiting" directory and
move them to the "running" directory once they are running. This allows
new updates to be persisted to the "waiting" directory while a similar
update is running without the waiting task getting deleted when the
persisted running task is deleted. On startup, reset all running tasks
by moving them back to the waiting directory to ensure that they are
retried.
Reset "running" tasks (return them to the "waiting" directory) when a
retry is rescheduled, this allows the retry to be consolidated with the
new run, and helps ensure that the persistence store reflects what is
actually happening better.
Bug: Issue 11672
Change-Id: Ia31329e8d939f8e5cb1e7455de69744431f34d66
* Update plugins/replication from branch 'master'
to 7a130c30c42ca8bc1e8858513ee8643ca6041b3a
- Get a URI lock before running tasks.
This allows more than one related gerrit process (as in multi-master
situations) to access the persistent task store at the same time without
deleting each other's task files. This also prevents more than one gerrit
process from pushing to the same URI at the same time.
Change-Id: I1f3f4d60605ff21038e722553cb38494e18b9ff9
* Update plugins/replication from branch 'master'
to 51750cae8ba3c68bcefedbe8b05faabf9ea5ada4
- Create persistent task files safely
Use a temporary directory to create the files in first to avoid
partially written files being exposed in the waiting directory.
Change-Id: I82222e16b52926ced304cb24eadd1c8d56cf9a7a
* Update plugins/replication from branch 'master'
to 48ff6f398941572243a0fd7aa26e07d6c95696a1
- Fix potential loss of persisted replication task
There was a race window between the check to see if any new updates were
available for the completed update and the deletion of the persistent
update. If an update occurred in that window it could leave the event
missing from the persisted task store. If the server went down before
this update completed, the update would be missed entirely.
Eliminate the race by separating the running tasks from the waiting
tasks in the persistent store by placing each into their own
subdirectories. Place new waiting tasks in a "waiting" directory and
move them to the "running" directory once they are running. This allows
new updates to be persisted to the "waiting" directory while a similar
update is running without the waiting task getting deleted when the
persisted running task is deleted. On startup, reset all running tasks
by moving them back to the waiting directory to ensure that they are
retried.
Reset "running" tasks (return them to the "waiting" directory) when a
retry is rescheduled, this allows the retry to be consolidated with the
new run, and helps ensure that the persistence store reflects what is
actually happening better.
Bug: Issue 11672
Change-Id: Ia31329e8d939f8e5cb1e7455de69744431f34d66
* Update plugins/replication from fefba17b04224e9346a50f6e66944142f4878179
to 94a465e0989ff8124aca3dca8e200aeb870cc9dd
- Merge "Decouple observable queue implementation from ReplicationQueue"
- Decouple observable queue implementation from ReplicationQueue
Prior to this change, AutoReloadRunnable used to depend on
ReplicationQueue, which was used just to observe the status of the queue
during the run() phase of the reloading.
Decouple reloading of configuration from specific queue implementations
by depending only on a way to observe the queue, rather than the queue
itself.
Incidentally, allow AutoReloadRunnable to be reused by implementations
that use a different queueing systems, or no queuing at all, such
as the pull-replication.
Change-Id: I589c5bf3fb49a53734ba3a991d08db33bc189d3e
- Merge "Move isSingleProjectMatch() to RemoteConfiguration interface"
- Merge "Make persistent task keys stable"
- Merge "Persist tasks before scheduling replication"
- Move isSingleProjectMatch() to RemoteConfiguration interface
The logic used to identify whether a configuration is related to a
single project as opposed to a family of project, is the same across
destination or source targets.
Provide a default isSingleProjectMatch method so that it can be
leveraged by both replication (for DestinationConfiguration) and by
pull-replication (for SourceConfiguration)
Change-Id: I1a366841e77755a1d17cfd9f68fe235a7a099f48
- Make persistent task keys stable
GSON was used to create json as the input for sha1 task keys, however
gson can order the json keys differently anytime. Use the values in a
specific order to create stable keys.
Bug: Issue 11760
Change-Id: I6900b5ddb3ba8ab7b5cf7803ae9dd551b5980a59
- Persist tasks before scheduling replication
Consolidate the replication firing paths and in doing so improve the
replicate-all path to persist events before scheduling them, thus
reducing the chance the task could be lost on server interruption. This
consolidation also has the side effect of adding replicate-all events to
the "beforeStartupEventsQueue" if they somehow happen to get fired
before replication is started.
Change-Id: Iaadbb89c4e5bc2f0eb751d26059868ba9cb7e9d7
Change-Id: I3b9da087264124d3b41224d4d754f4a1c44a566b
* Update plugins/replication from branch 'master'
to 94a465e0989ff8124aca3dca8e200aeb870cc9dd
- Merge "Decouple observable queue implementation from ReplicationQueue"
- Decouple observable queue implementation from ReplicationQueue
Prior to this change, AutoReloadRunnable used to depend on
ReplicationQueue, which was used just to observe the status of the queue
during the run() phase of the reloading.
Decouple reloading of configuration from specific queue implementations
by depending only on a way to observe the queue, rather than the queue
itself.
Incidentally, allow AutoReloadRunnable to be reused by implementations
that use a different queueing systems, or no queuing at all, such
as the pull-replication.
Change-Id: I589c5bf3fb49a53734ba3a991d08db33bc189d3e
* Update plugins/replication from branch 'master'
to 6236969ab60c7f3b943bfafe822ab945c70838b7
- Merge "Move isSingleProjectMatch() to RemoteConfiguration interface"
- Move isSingleProjectMatch() to RemoteConfiguration interface
The logic used to identify whether a configuration is related to a
single project as opposed to a family of project, is the same across
destination or source targets.
Provide a default isSingleProjectMatch method so that it can be
leveraged by both replication (for DestinationConfiguration) and by
pull-replication (for SourceConfiguration)
Change-Id: I1a366841e77755a1d17cfd9f68fe235a7a099f48
* Update plugins/replication from branch 'master'
to f1cf5e878f2934573c6667adee99ca45f76815a0
- Merge "Make persistent task keys stable"
- Make persistent task keys stable
GSON was used to create json as the input for sha1 task keys, however
gson can order the json keys differently anytime. Use the values in a
specific order to create stable keys.
Bug: Issue 11760
Change-Id: I6900b5ddb3ba8ab7b5cf7803ae9dd551b5980a59
* Update plugins/replication from branch 'master'
to 31025f1a1179c4fb7da52408666ee209222d57bb
- Merge "Persist tasks before scheduling replication"
- Persist tasks before scheduling replication
Consolidate the replication firing paths and in doing so improve the
replicate-all path to persist events before scheduling them, thus
reducing the chance the task could be lost on server interruption. This
consolidation also has the side effect of adding replicate-all events to
the "beforeStartupEventsQueue" if they somehow happen to get fired
before replication is started.
Change-Id: Iaadbb89c4e5bc2f0eb751d26059868ba9cb7e9d7
* Update plugins/codemirror-editor from branch 'master'
to 92ce310ecf717133601b9e824c38bc5e5eafecba
- Add django, handlebars, jinja2, rpm and sparql languages
Change-Id: Idbaf522cccf1c676f64c86d1114fe652dc36074e
* Update plugins/replication from branch 'master'
to fefba17b04224e9346a50f6e66944142f4878179
- Merge "Fix firing pending "..all.." events on startup"
- Fix firing pending "..all.." events on startup
The Destination.wouldPushRef() method is called on startup to see if a
Destination is configured to be pushed to for a specific ref, if it is
not configured to do so, then firing the pending update is skipped.
Since the magic "..all.." ref will never match the configuration in
replication.config, always match it since if replication is configured
at all, then it should be matched.
Bug: Issue 11745
Change-Id: I53bd527932e6aea9ddd465772925d601aa034bd3
This is long overdue renaming step to manifest that SQL database is
removed from gerrit core. Moreover, client/server package division
was needed due to GWT UI that was removed as well in release 3.0.
Bug: Issue 11678
Change-Id: Icfd83a309a6affac54141e7284e70f1255537dc4
* Update plugins/replication from branch 'master'
to d8194b291bb0433b5c3abe059ebad6f00fcb3a22
- Generalize replication configuration type
Configuration is tightly coupled to destination configuration, however
this can be abstracted away so that different type of configurations can
be plugged in at runtime.
Introduce the concept of RemoteConfiguration, so that pull-replication
can leverage the existing configuration classes and auto-reload
mechanism.
Feature: Issue 11751
Change-Id: I4ca494feb11c02b6f75b665815d8a0f43dcff8bb
This is the second attempt to build JGit from the source using git
submodule approach. The first attempt that was abandoned is here: [1].
Using a submodule to bring in the source files vastly simplifies
updating JGit. Gerrit developers can bump the SHA-1 of the submodule
and not deal with the Maven rebuild process for JGit.
This change updates JGit dependency from 5.4.3.201909031940-r to commit
009e07882fee2b0ad2ebe7ba44e2ff52c101f858, and Javadoc version from:
5.4.3.201909031940-r to 5.5.0.201909110433-r.
To bump to new Javadoc API _DOC_VERS should be updated in
java/com/google/gerrit/extensions/BUILD to point to the desired JGit
Javadoc release.
JGit sources are imported in Eclipse as source folders. One side effect
of this change is that the source code warnings for JGit project are now
shown.
[1] https://gerrit-review.googlesource.com/c/gerrit/+/61892
Feature: Issue 11737
Change-Id: I16370e57f27e26b2382243ca448484f53dfa96bb
* Update plugins/replication from branch 'master'
to 3bd8b958d4afbd06fbe43edec24d03d8d386d2e1
- Make replaceName and getConfig public
replaceName and getConfig should have public access so that they can be
used from pull-replication too
Change-Id: I601a746c451c242c93975358d770b6b64cd801ff
* Update plugins/replication from branch 'master'
to 1bcdf90a1eed4227491b6e41f2a97065c273222c
- Remove duplicate replaceName method
replaceName was duplicated into DestinationCollection, but can be
statically accessed from ReplicationFileBasedConfig
Change-Id: Id56cc2b677247876088e7d96ba17371ba566bbb2
* Update plugins/replication from branch 'master'
to c09a7c08fb44094c7475313ac52154adac39a54c
- Make SecureCredentialsFactory public
Access to secure.config is useful to more than just replication plugin.
Allow instantiating this class from packages other than replication
plugin. Specifically this is useful, as this class can be used from
pull-replication too.
Change-Id: Id268c869e993c6cabacfa0043ec269172e0efba1
* Update plugins/webhooks from branch 'master'
to e26745604c1f4301cf5d130d4bcc9da8463e0b1a
- Bazel: Use test dependencies directly in junit_tests rule
Also remove local tag, because the tests can also be executed
sandboxed.
Change-Id: I38a10423b6ddf4cd297951db86a87ddc819a642f
