Some admin tables (for example plugins) don't have APIs that support
filtering and pagination. It is still advantageous to share styles,
so pull that out into a separate element.
Change-Id: Iad2b40d9af3cc53351973c7c456f1110424a14df
Even though a gr-list-view element has been established for many of the
common list view functions, The tables themselves are still
generated by the parent element and passed as <content>. There were
many common functions used in the table generation itself.
Break out those common functions into a behavior, and implement in
gr-admin-group-list and gr-admin-project list. This will be used in
further admin pages as well.
Change-Id: I60227b8c30ac18176bbf923ee1fb02bdd985e5c3
* changes:
Highlight hunks which are due to rebase on PolyGerrit
Copy due_to_rebase to subgroups in gr-diff-processor
Move diff tests from RevisionIT to RevisionDiffIT
Mark hunks which are present due to a rebase when diffing patch sets
Previously, in the projects page, when a new page was loaded, the old
content stuck around. Make sure it dissapears when the loading text
is visible.
Similarly, in the gr-admin-group page, show the loading text and also
remove results when a new page is requested.
In both cases, uses css to display: none rather than the hidden
attribute.
Bug: Issue 6433
Change-Id: I3f8166532d39efc318a2daf1d5f5110c17fffdf6
Add box-sizing: border-box to css reset. In a variety of places, there
was content overlap, coming from where padding was set with a width of
100%. Setting box-sizing: border-box in the css reset allows for
padding to be set with a 100% width.
Bug: Issue 6372
Change-Id: Id177a5c7b000b7bfb2cce456e4834104e8c7e912
There were a few issues with the height calculations:
- In the case of a large screen (not small or medium), the height used
to calculate existing height was the mainChangeInfo. When logged out,
this worked fine (in testing with run_server), but when logged in,
there is additional height from buttons. Instead use commitAndRelated.
- Add a little extra height as it seemed to be a bit under, perhaps
after some of the CSS changes.
- Add the line height calculation to small and medium sized screens too,
so that text is not cut off mid-line there either.
Bug: Issue 6458
Change-Id: Ibf1c1583b5288ea7f200686e287a48a419464104
- Made file list rows focusable for screen reader
- Removed enter as a file list keyboard shortcut
- Added a11ySuite to gr-file-list_test
Bug: Issue 6435
Change-Id: I4885370ffcf0e430c776cc83493e32f7fc6d2cf5
a11ySuite is a wct function that tests for basic a11y features. For
more, see https://goo.gl/P15eE6
Bug: Issue 6435
Change-Id: I6bb3852de43838b9d3009578cb42dfdfb02e9bff
The main.css styles took precedence over some of the ::content styles.
Add the table class to make these styles take precedence.
Change-Id: Idcc282be2cc299d82629c47fc2189cd9f4b01eb5
This is a partial roll-forward of c/106190.
It adds a dependency on the latest version of polymer-resin.
Later CLs will actually use this dependency.
Change-Id: I3cf5f9c823d74da58a8b1326153a672959fa3f13
Adds an aria-label to added and removed rows marking the row as "added"
or "removed" for screen readers. As part of this change, the <tr>
elements that make up the diff are now focusable.
Test plan:
- Somewhat included as a part of testing this functionality is the use
of WCT's a11ySuite function[1]. This will be introduced in a later
change.
[1] https://goo.gl/P15eE6
Bug: Issue 6435
Change-Id: I676fc171d404ca6e8e9276965192b1452595fa61
