After switching to Eclipse Maven repository for pulling JGit lib, we
have the problem that according to Eclipse release train the JARs have
to be signed. That collids with our jgit patch for diff deserialization.
To rectify that, add `unsign` parameter to maven_jar() function.
Change-Id: Ib7bfa5d16f980a64b887d61a4b4ec325e6ffb0a1
This change fixes the following problems:
* MAVEN_LOCAL definition must be prefixed with 'file://' for curl to work
* src_sha1 was unnecessary required to define source artifact
* update the documentation that sha1 must not be provided
Change-Id: I1cee6588897c928f01bac5cc9fb252251f4f8027
Standardize the definition of MAVEN_LOCAL as ~/.m2/repository.
This makes it slightly easier to point to a custom build of a
dependency such as gwtorm or PrologCafe by installing the JAR to
the local Maven repository and updating the maven_jar() rule to
use repository = MAVEN_LOCAL instead of GERRIT.
Change-Id: I2e54d1039608c0195a992dbc12fe74bb513466c6
shutil.copyfile can raise shutil.Error and IOError. Catch these and
exit with error status after logging the error to the console.
Change-Id: I63b8caa371cc7034bbb3f19d0bd3fdd0446af2bf
If extracting files fails, it prints the error message but then
continues.
Make it exit with error status in this case.
Change-Id: I19fafda68a85b46300a1abaf6a86567cf1f712b0
download_file caches original zips in ~/.gerritcodereview/buck-cache.
If this is a different filesystem than $(pwd)/buck-out a symlink
was used to connect the build file with the original archive. This
confuses Buck when creating the $SRCDIR for a genrule().
If a hardlink does not work, copy the file.
Change-Id: If66c59fb6aecc93b5a3e85cdd76ef880538875ff
Per [1] the correct URL is <bucket>.storage.googleapis.com/<object>.
Update existing references to project resources to use this domain
name instead of the old name.
[1] https://developers.google.com/storage/docs/reference-uris
Change-Id: I3788cfb4504b3908d2b5eccbdf52beffc3d18387
If buck build was done on a system without curl installed
a misleading error message would be printed out:
error creating directory /home/user/.gerritcodereview/buck-cache
However, the real error was that invocation of curl failed. Since
it was an OSError it was handled with the wrong except block.
Separate handling of the OSError for the folder creation and curl
invocation.
Change-Id: Ic7e7c2c2704ea4cbccff4689dffe17a436108395
If the SHA-1 does not match the downloaded file content, delete the
file from the cache. This allows a user to fix whatever connectivity
problem led to the corruption and re-run buck build to download
the correct content.
Change-Id: I2f72fb2b187675ec9d5cda650d8982bc93a00189
This is a generic downloader that can be used for other
dependencies, like ZIP files containing JS.
Change-Id: I643f81fc06d790cebaa0eb677fa232ba0c652053
