opendev/gerrit
Code Issues Proposed changes
18,440 Commits 1 Branch 360 Tags
180693c180
Commit Graph

10 Commits

Author SHA1 Message Date
Urs Wolfer
c37b69ab9b Fix issues detected by 'JSHint' and 'JSCS' 
Change-Id: Ibee5d0843da5776ab1ad43158227178105467d2e
 2016-04-29 22:25:51 +02:00
Andrew Bonventre
c80291ca05 Move gr-diff controls into gr-diff-view 
This will allow for an easier time in implementing expanding
inline diffs by having gr-diff only responsible for rendering the
diff itself and not other controls.

Change-Id: I254ad5900091c731e2197590d6043c103216785e
 2016-04-23 23:28:55 -04:00
Andrew Bonventre
102f8793a7 Fix bug where copying text inside a comment box wasn’t working 
Change-Id: Ifc4866f82fab22db21c2494601ae4173e2c46af5
 2016-04-22 16:01:12 +00:00
Andrew Bonventre
1c75cebe0a Show errors on views when main requests fail 
Bug: Issue 3953
Change-Id: Ic20ac5cfc8cbf25c0744e0208b60f447ba9da718
 2016-04-05 20:08:03 +00:00
Andrew Bonventre
1508cac26d Switch to using fetch for gr-change-actions 
Bug: Issue 3945
Bug: Issue 3988
Change-Id: I471c63695300b2e410013d637285f897c4f6c703
 2016-04-05 09:54:33 -04:00
Andrew Bonventre
2aa22125b6 Move gr-diff-new to gr-diff 
Change-Id: Ifaad016f806c31f3df43143b3238b757faa18b20
 2016-03-25 17:56:08 -04:00
Urs Wolfer
f531d0aeb9 Fix tests which are wonky in Safari 
Change-Id: I5f60afd9302581204c9ab08eda10a2273677b4fa
 2016-03-14 17:12:03 +01:00
Andrew Bonventre
af1c602139 Fetch diff comments via getDiffComments call 
+ Cleans up interface for grouping comments within
  gr-rest-api-interface.
+ Removes gr-diff’s dep on gr-ajax and rest-client-behavior.

Change-Id: Idea54a38fa5d0b136ff00b7ec7322bd24ad5d1bd
 2016-03-07 16:55:04 -05:00
Andrew Bonventre
cba7d44e69 Add getDiff() method to gr-rest-api-interface 
+ Replace use of gr-ajax for retrieving the diff in gr-diff.
+ Add opt_params to fetchJSON so that query parameters can be
  passed.

Change-Id: Iaa77c4082d6e83099e23f49205d859a5c938dd31
 2016-03-05 19:20:09 -05:00
Andrew Bonventre
78792e8e98 Refactor directory structure of components 
There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513
 2016-03-04 18:02:24 -05:00