opendev/gerrit
Code Issues Proposed changes
18,214 Commits 1 Branch 360 Tags
2c6e16282a
Commit Graph

9 Commits

Author SHA1 Message Date
Andrew Bonventre
2c6e16282a Refine sorting within the file list 
+ Always place the Commit message at the top.
+ Put {.h|.hxx|.hpp} files before others with the same base name.

Bug: Issue 3852
Bug: Issue 4065
Change-Id: I5295a19734711516c69831fd8250f13f962cbba2
 2016-04-15 18:27:01 +00:00
Andrew Bonventre
5bee101aa2 Lose the extra horizontal margins on views 
Also get rid of some !important declarations since they were
there to deal with a Polymer specificity bug which has since
been fixed.

Change-Id: Ie7bf8682d52ecf05af920c8a7d67701e629f3e59
 2016-04-07 22:03:44 -04:00
Andrew Bonventre
30344cc9a3 Remove gr-ajax/gr-request from gr-diff-view 
Bug: Issue 3988
Change-Id: Ia34d881e7eb12904971c3cc47cac5aa1dbe08a3f
 2016-04-05 16:49:13 -04:00
Andrew Bonventre
cfacb80095 Remove final uses of app.accountReady 
Change-Id: I9ed0591d3c0fa673a7bcadbbee0b998b0a57eb05
 2016-03-29 14:21:15 -04:00
Andrew Bonventre
2aa22125b6 Move gr-diff-new to gr-diff 
Change-Id: Ifaad016f806c31f3df43143b3238b757faa18b20
 2016-03-25 17:56:08 -04:00
Andrew Bonventre
3509f8144f Fix failing gr-diff-view test 
iron-a11y-keys-behavior doesn’t like commas apparently.

The keyboard shortcuts should call preventDefault() anyway, so
this is a proper fix that prevents the test key event from bubbling
up to the iron-a11y-keys-behavior logic.

Change-Id: I4b8120556db9146aa5eb9669db26e1737b031b51
 2016-03-11 12:35:48 -05:00
Andrew Bonventre
8e5ac9d92a Move fake-app.js to test folder 
Also exclude *_test.html files from BUCK app glob

Change-Id: If1890b46ffb7d4657bdea83786de5262343835ff
 2016-03-10 19:30:31 -05:00
Urs Wolfer
b603694158 Remove 'element#async' usages in tests 
Tests which are using 'element#async' are wonky in Safari.
'flush' is also the documented way of testing dom manipulations.

Change-Id: I3ea99c7c80c952fa1c15bbd6289690e57bf8414b
 2016-03-06 17:23:36 +01:00
Andrew Bonventre
78792e8e98 Refactor directory structure of components 
There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513
 2016-03-04 18:02:24 -05:00