This was presumably fixed in Ia5e6b9791 and in I8b735db4f. It turns
out, that labels map is not null in GWT UI, as it is the case in PG,
but also non empty, even in non-voting case: Code-Review: 0.
Fix the optimization check to account for zero votes.
Bug: Issue 4638
Change-Id: I6d9a2cc42ec51e6b1df13b96cf4bcdd082c87f60
Having a standard tool for formatting saves reviewers' valuable time.
google-java-format is Google's standard formatter and is somewhat
inspired by gofmt[1]. This commit formats everything using
google-java-format version 1.2.
The downside of this one-off formatting is breaking blame. This can be
somewhat hacked around with a tool like git-hyper-blame[2], but it's
definitely not optimal until/unless this kind of feature makes its way
to git core.
Not in this change:
* Tool support, e.g. Eclipse. The command must be run manually [3].
* Documentation of best practice, e.g. new 100-column default.
[1] https://talks.golang.org/2015/gofmt-en.slide#3
[2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
[3] git ls-files | grep java$ | xargs google-java-format -i
Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
The 'seed' packages are the ones whose versions are set by us in
WORKSPACE. We should not set the versions for the rest of the packages
in the bower input JSON, so bower can suggest the right versions to
use.
Change-Id: I9b75f16655d049e2064726862980a339c91dd534
In the definition of //lib/powermock:powermock the dependency to
@powermock_core//jar was missing.
Change-Id: I4055085592ad556e7b1da730344b7e48460be7af
This snapshot includes several fixes since the release, including some
improvements in LFS support:
d3148f300 Make ObjectDownloadListener public
55c629a9f LfsProtocolServlet#LfsRequest: Add operation type helper methods
56fe21778 Expose LFS operation strings as public constants
590141163 LfsProtocolServlet: Improve error on getLargeFileRepository failure
7245aa031 Add support for refusing LFS request due to invalid authorization
0e187f148 Add LfsPointerFilter TreeFilter
Change-Id: Ib3cd9d8677b6c6017becc5c46e7fa4dfc5192807
Change-Id: Ibd58603e6c1975c883dbf9f1d115e03a25467774
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
Highlights include:
- New themes duotone-light and duotone-dark
- Various small fixes to language modes
Change-Id: I632cc2dd3815767293ea9638b0551f7a98f330b2
$ git log --oneline v1.16..v1.17
09ada04 Version 1.17
4ce1c32 JdbcAccess: Defer exceptions when in a transaction
b46ab3e Incorporate table into H2 column constraint name
0bfc2e3 Start 1.17
Change-Id: Iee0002cbc74678cac53c1931acf1bea92ef25c7e
Remove unnecessary java_library rule wrapper around another
java_library defined through maven_jar rule.
Change-Id: I197df73f8944b9d17c7738c036035b2daccd8e61
Remove unnecessary java_library rule wrappers around another
java_library defined through maven_jar rule.
Change-Id: I5df214dccf419bbf745babda6ee9ccd7f4905b72
Remove unnecessary java_library rule wrappers around another
java_library defined through maven_jar rule.
Change-Id: Ibb6d52d210e2ba1f2569177d232f41b7a67a6a7f
Instead, use a hard-coded map of licenses.
Hardcode a false dependency on diff-match-patch to avoid a diff for
the Apache2.0 license.
Tested:
bazel build Documentation:js_licenses.txt
buck build Documentation:js_licenses.txt
diff -u buck-out/gen/Documentation/js_licenses.txt/js_licenses.txt \
bazel-genfiles/Documentation/js_licenses.txt
diff shows only diffs for added [[header]] anchors.
Change-Id: I7886e1fadec900cf854a1b3b7c538b83d66af7a4
Output the actual jar path used for the build in the generated JS
file, rather than a broken Google Code link. This requires extracting
a constant for the version string.
Rename the addon_merge target to indicate that it includes bundled
dependency code from diff-match-patch, which fact is not otherwise
obvious.
Change-Id: I6512e5d65b81802d917f718f8e62ac414e8bffda
Given that Bazel activates error prone static analyzer per default,
allow to activate it for Buck as well. We already monkey patch
java_library and java_test rules, so it's trivial to munge javac_jar
and compiler_class_name attributes as well.
Due to compile performance coniderations and some issues that were
reported with error prone activated by default in Buck driven build,
we make the integration optional and disabled by default. There are
two option to activate it:
1. Add these lines to your private .buckconfig.local to permanently
activate error prone checks:
[sanitizers]
error_prone = 1
2. Use this config option to instantly run error prone check:
buck build --config sanitizers.error_prone=1 gerrit
Error prone has an issue with naming artifact with all transitive
dependencies included: while it has the suffix "ant", it should be
just called "all". But, TBH, we don't care.
Error Prone is Google library and is released under Apache 2 license.
Change-Id: I2bbe0313ad3e54df1d52968cc28d7e13db36d83f
Reformat the Bazel build files with the buildifier tool [1].
The style is different for Bazel files. Most notably, indentation level
is 4 spaces instead of 2, and " is used instead of '.
[1] https://github.com/bazelbuild/buildifier
Change-Id: I95c0c6f11b6d76572797853b4ebb5cee5ebd3c98
JavaEWAH was upgraded in JGit in [1], which is included in the snapshot
build of JGit being used in Gerrit since change Ic7c646b32.
Upgrade to use the same version.
[1] https://git.eclipse.org/r/#/c/77604/
Change-Id: I5de4cdbdf816296d97640bb83130544ec85685af
This lets us associate the jar and the src jar in the java_import()
declaration, so IDE plugins could understand how artifacts and source
are connected.
Classpath generation for Eclipse IDE was adjusted to reflect the changed
location of the source artifact.
Change-Id: I2cf9c6db3ad4b648457f2ac8d380c3771b4a3ee2
gwt_binary() uses Bazel feature to retrieve the sources from the
dependency libraries. For the standalone API this feature cannot be
used as the only dependency is GWT UI plugin API. Expose the sources
in GWT UI plugin API as well.
TEST PLAN:
Apply this change and create the plugin API:
$ ./tools/maven/api.sh install
Apply reviewers plugin Bazel build implementation change: [1] and
verify, that the reviewers plugin can be built with the GWT UI plugin
API created with this change.
[1] https://gerrit-review.googlesource.com/91830
Change-Id: I2b065a8eccbc33020d461834704d684871f463d7
Adds support for MonotonicClock, which Gerrit can use
inside of ReviewDb and NoteDb to maintain timestamps.
Change-Id: Ic7c646b32644c1d1b1e93eeb50a3bf153e85d3c3
TEST PLAN:
$ bazel build plugins/cookbook-plugin
Deploy to the server site and verify that it works.
Change-Id: I98af807f9c92ba4ed7efad332d8fdee407bb8ce6
Includes {get,set}GitwebDescription on Repository,
which can replace methods in GitRepositoryManager.
Change-Id: Ie25a49864c770e1cfb065dfc9e7c1e8faa97b03c
Using existing download_file.py from custom maven_jar Skylark rule
gives us the following advantages:
* fetching of sources (needed for GWT JSNI build and IDE integration)
* server support for proxies
* global, per-user cache of artifacts
* support for local maven repository (~/.m2)
Change-Id: Ic246dd9298775a6819f05453c601c688d8cb7ab9
Packs fonts the same way bower_components are packed, with a 'fonts'
folder inside fonts.zip.
Also removes deprecated OpenSans fonts from build files.
Bug: Issue 4893
Change-Id: I7fc11d6e689c7d5b1d68d09e94ee7aaba91ded9b
This change adds a parser to parse raw emails received by either POP3 or
IMAP into a MailMessage. It adds a dependency to Apache Mime4j to handle
the mime message parsing and tests.
Change-Id: I97ead9615ffcd0a7839ae1aa1581be4005cf67f1
This commit implements the basic class structure for receiving emails,
all required config parameters, all necessary bindings depending on
which protocol the administrator has configured and updates the
documentation accordingly.
It also adds test-only dependencies to Greenmail and javax.mail. These
will be used to create integration tests.
It's the first change in a topic of changes to implement email ingestion
for Gerrit.
Change-Id: I0edec7ca2655fcd70284bb75ca8eb94ce2491d7a
Among other this version fixed "Compile-time constant expression
overflows" bug, reported by Bazel 0.4.0. Other fixes and improvements
are here: [1].
This upgrade is needed to be able to support Bazel 0.4.0.
[1] https://github.com/google/auto/releases/tag/auto-value-1.4-rc1
Change-Id: I2e792bae1afa276efdf1580b6543fdc0cec6d45c
* stable-2.13:
Fix to reindex a change via SSH: get from DB/Notes instead of Lucene
Update git submodules
Fix Postgresql JDBC driver leaking memory
Fix Schema_127 for mysql on case-sensitive FS
Update git submodules
Change-Id: Ida6a895ccb8cab2c68bb0cdb83fe4d076f2b007c
Older versions of Postgresql JDBC driver rely on finalize() methods in
order to avoid leaking unclosed database objects. Given finalize
methods are unpredictable (no guarantee about prompt execution, if at
all), in some high load environments this could lead to a memory leak
with millions of JDBC objects pending finalization.
Newer versions of the Postgresql JDBC driver removed the use of finalize
methods to avoid this kind of issues.
Bug: Issue 4848
Change-Id: Ia143f1df1d8e41686362fd76b9bc82e0046f9894
Move the definitions of GUAVA_VERSION and GUAVA_DOC_URL into a
separate .bzl file, and add GUAVA_BIN_SHA1. Modify the existing
GUAVA_VERSION file to include the new .bzl file.
This allows to reuse the same values in both the buck and bazel
builds, and when we update Guava we only need to modify one file.
Update the bazel build of the extension API to include the Guava
Javadoc URL in the javadoc rule.
Change-Id: I7895ceb761d609d79d3b80a271e6bd7425c17e2b
