17 Commits

Author SHA1 Message Date
David Ostrovsky
20c2fd4f0b Bazel: Add fixes for --incompatible_load_{java|python}_rules_from_bzl
This change is fixing "All Java build rules should be loaded from
Starlark" warning flagged by latest buildifier version: [1]. Python
rules are now also loaded from the Starlark.

Also extract codemirror library import to BUILD file. This is needed to
avoid cycle in the workspace file, after importing java rules from
Starlark.

[1] https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#native-java

Change-Id: I36192c9465d988b25cf09c250e110f15850910cd
2019-09-02 00:42:25 +02:00
Han-Wen Nienhuys
b6a4048986 Apply buildifier to .bzl files.
Buildifier is now also used for formatting .bzl files.

This change was created by running buildifier 0.12 over our source tree.

Change-Id: I9f15112d4fe23e5cec0700cfe47f1ca649f61d2a
2018-07-10 20:38:52 +09:00
David Ostrovsky
f98a60b35f Bazel: Harmonize names of external repositories
Recent Bazel versions support dash character in external repository
names. Consistently use them with one exception: javax_inject. This is
needed to match the name in the rules_closure.

Change-Id: I1e75690fe1ee2ab32fffe07c0c30dbed84753960
2018-06-08 19:33:01 +09:00
Paladox none
d1dab17ce4 Update codemirror to 5.25.0
See release notes at https://codemirror.net/doc/releases.html

Change-Id: Ia55811afecc9bc6c2fcf0a0edaa9a35b05152ae4
2017-03-22 21:44:40 +00:00
Paladox none
33d4eafec0 Update CodeMirror to 5.24.2
Change-Id: I9e86bdb59b5f9295bc1ff50e04174856e5b00444
2017-02-22 23:24:18 +00:00
Paladox
1e55a382d6 Update codemirror to 5.22.0
Highlights include:
 - New themes duotone-light and duotone-dark
 - Various small fixes to language modes

Change-Id: I632cc2dd3815767293ea9638b0551f7a98f330b2
2016-12-22 23:40:25 -04:00
Han-Wen Nienhuys
42ea853037 bazel: remove code to sniff license field in bower.json.
Instead, use a hard-coded map of licenses.

Hardcode a false dependency on diff-match-patch to avoid a diff for
the Apache2.0 license.

Tested:
  bazel build Documentation:js_licenses.txt
  buck build Documentation:js_licenses.txt
  diff -u  buck-out/gen/Documentation/js_licenses.txt/js_licenses.txt \
    bazel-genfiles/Documentation/js_licenses.txt
 diff shows only diffs for added [[header]] anchors.

Change-Id: I7886e1fadec900cf854a1b3b7c538b83d66af7a4
2016-12-20 15:44:52 +01:00
Dave Borowitz
8cadb33267 Improve documentation of diff-match-patch build
Output the actual jar path used for the build in the generated JS
file, rather than a broken Google Code link. This requires extracting
a constant for the version string.

Rename the addon_merge target to indicate that it includes bundled
dependency code from diff-match-patch, which fact is not otherwise
obvious.

Change-Id: I6512e5d65b81802d917f718f8e62ac414e8bffda
2016-12-19 16:51:56 -05:00
Han-Wen Nienhuys
238c6e9763 Add license for diff-match-patch JS.
Fix dependencies for codemirror targets.

Change-Id: Ibda5573438b0ab76c42f5faaa3a463b5975bd43c
2016-12-19 11:53:43 +01:00
David Pursehouse
2d08500516 Format .bzl files with Bazel Buildifier
Change-Id: I3ab30565e5ac110a18cbe3d34f76307801c30373
2016-12-11 19:00:21 +09:00
David Ostrovsky
76eac6f3fc Bazel: Fix build
Iaab184501 renamed out to outs in genrule2, but missed to replace some
places.

Change-Id: I3e9673b95ab7e6ff8cd0feab42d5c7569297be54
2016-11-03 08:06:21 +01:00
Han-Wen Nienhuys
29cced5e29 bazel: remove 'out' attribute from genrule2, and use throughout.
This centralizes the OSX mktemp solution.

Change-Id: Iaab18450146b649245b36865bedc5d7b50d1aa07
2016-11-02 13:54:10 +01:00
Han-Wen Nienhuys
c9be186e0a bazel: Fix codemirror license name.
Change-Id: Ice7ab6e946cf70f44dcf513c1598a495307f42aa
2016-09-28 17:32:09 +02:00
David Pursehouse
7c1d6f6f35 Merge "Update CodeMirror to 5.19.0" 2016-09-27 01:38:48 +00:00
Yuxuan 'fishy' Wang
75b98f77d9 bazel: add license to appropriate lib/ targets
This is to prepare for implementing genlicenses rule in bazel.

Change-Id: I60d79d5b53f9dd05c9f9ebfe6e6f658604c5a037
2016-09-26 16:42:38 +08:00
Michael Zhou
0284c79052 Update CodeMirror to 5.19.0
Highlights include:
  - javascript mode: Better indentation when semicolons are missing.
    Better support for TypeScript classes, optional parameters, and the
    type keyword.

Change-Id: I7a46c8dc058278ce484dacfa870050ed4c04f2eb
2016-09-26 03:20:20 -04:00
David Ostrovsky
868b68dd6c Implement Bazel build for codemirror library
This is more or less straightforward migration of Buck codemirror
packaging rules: "jar" with non-minified JS version and "jar_r"
with minified JS version.

TEST PLAN:

  bazel build //lib/codemirror:codemirror
  bazel build //lib/codemirror:codemirror_r

Change-Id: I68a22902b5a24af9aa9479d27e6d160978631108
2016-09-20 09:25:26 +02:00