So far the net.logstash.log4j.jsonevent-layout package was used to
format the error logs to JSON. This format was not suitable for the
httpd- and sshd logs and thus was not used there. Also the format
provided by the dependency was not configurable, e.g. did not allow
to change the timestamp. This resulted in different timestamp formats
for the text- and the json-formatted error logs.
To be more flexible in the formatting of the json logs, this change
removes the dependency. It keeps however the ISO8601-formatted timestamp,
but adds the timezone offset and thus does not assume the UTC timezone.
In a followup change the timestamps of all logs will be adapted to the
same standard.
Change-Id: I3a2bdba5d4b25067d0324fb63438e2a6ec726c68
* stable-3.1:
UrlFormatter: Fix Javadoc of getSettingsUrl()
Add a separator between blame and the edit icon
Remove target=_self from commentlinks
Update .mailmap
Update .gitreview file
ReceiveCommits: Factor repeated "internal server error" text to a constant
Update .mailmap
Documentation: Add site-path arg to reindex command
Isolate log4j dep
gr-diff-builder: Remove unused function renderSection
Update .mailmap
Cancel deprecation of change identifiers
FakeGroupAuditService: Make auditEvents final
ErrorProne: Increase severity of MutableConstantField to ERROR
ConfigUpdatedEvent: Use immutable type in field declaration
gr-diff-processor: remove unused resolve value
Add missing slf4j dependencies in BUILD file
JGitMetricModule: fix WindowCache miss ration which wasn't reported
Revert "JGitMetricModule: Replace anonymous Supplier instances with method references"
Suppress generic logging on docker start for ElasticSearch container
Replace deprecated OptionParser with ArgumentParser
Documentation: Replace plugins list with home page
Change-Id: I93e54874d7bba26120e609b4ea81a7c41ee88deb
* stable-3.0:
UrlFormatter: Fix Javadoc of getSettingsUrl()
Add a separator between blame and the edit icon
Remove target=_self from commentlinks
Update .mailmap
ReceiveCommits: Factor repeated "internal server error" text to a constant
Update .mailmap
Documentation: Add site-path arg to reindex command
Isolate log4j dep
Update .mailmap
Cancel deprecation of change identifiers
FakeGroupAuditService: Make auditEvents final
ErrorProne: Increase severity of MutableConstantField to ERROR
ConfigUpdatedEvent: Use immutable type in field declaration
Add missing slf4j dependencies in BUILD file
JGitMetricModule: fix WindowCache miss ration which wasn't reported
Revert "JGitMetricModule: Replace anonymous Supplier instances with method references"
Suppress generic logging on docker start for ElasticSearch container
Replace deprecated OptionParser with ArgumentParser
Documentation: Replace plugins list with home page
Change-Id: Idae7755cb887a8df60028a96fff0a01d5d637f8a
* stable-2.16:
FakeGroupAuditService: Make auditEvents final
ErrorProne: Increase severity of MutableConstantField to ERROR
ConfigUpdatedEvent: Use immutable type in field declaration
Add missing slf4j dependencies in BUILD file
JGitMetricModule: fix WindowCache miss ration which wasn't reported
Revert "JGitMetricModule: Replace anonymous Supplier instances with method references"
Suppress generic logging on docker start for ElasticSearch container
Replace deprecated OptionParser with ArgumentParser
Change-Id: I36a7ce5c043bd43d90fb415fcec67440db2b5c84
foo.com@test.com should be recognized as an email.
currently because url patterns are matched before email pattern,
so it will be recognized as two urls instead of one email.
As upstream for ba-linkify has not been updated for 10 years: https://github.com/cowboy/javascript-linkify
Will propose to fix it in local copy directly.
Change-Id: I1f33cd600885b759d2e2707fe97a72f4bc656248
slf4j dependencies were not included in the BUILD file (I43e6cf797cc)
which cause the Bazel build to fail when attempting to run the tests.
Change-Id: Ie5c8bbb80625453a066e29f92660da7b0e5c8674
JGit 5.1.13.202002110435-r adds
- new WindowCache metrics
- and enables using strong references to reference cache pages in the
WindowCache. Set core.packedGitUseStrongRefs = true to enable using
strong references to reference packfile pages cached in the WindowCache.
If this option is set Java gc can no longer flush the WindowCache to
free memory if the used heap comes close to the maximum heap size. On
the other hand this provides more predictable performance.
Change-Id: I895369a8596dfc5adce76c65202ecf37e6a8386d
All unused bower components and rules are removed. Some rules
are not removed because they are used by plugins. We should keep them
until all core plugins get rid of bower components.
Change-Id: I6e6b5a3805fd68e7e438135c9b60e9d732cb8092
This change uses node modules to build polygerrit-ui release artifact.
Tests still use bower_components.
Change-Id: I3457931b0ff8edcb41250d1aa3518b8ea18a964e
This change:
* adds dependencies to polygerrit-ui package.json files
and defines licenses for polygerrit-ui/app dependencies.
* generates new licenses.txt files. Because bower
components are still in use, licenses for js packages
appear twice in .txt file. In the following change duplicated
licenses are removed.
This is the reason for the following warning:
WARNING: ..id assigned to block already in use: ...
Fixed in other change in the chain.
The packages from package.json are not used to build final
artifact (gerrit.war), so frontend still uses Polymer 2.
Change-Id: I7dc91a89640f607abc4e0c9e3577786663daa3de
* stable-3.0:
Update web-component-tester to 6.5.1
Add support for Elasticsearch version 7.6.*
Error Prone: Enable and fix ClassCanBeStatic
Write upload-pack metrics to sshd log
Change-Id: I533d5ca030b608399cc56e7905c9c5b6e6a994bc
This reverts commit 48026defc8ae48e76f29a583544779f7295446a6.
And also add changes to update wct to 6.5.1 and rerun
"tools/js/bower2bazel.py" to update bower_archives
Change-Id: I0eb5c7c5e11fc16e17bd0f35576631d1e1794a2d
JGit 5.3.7.202002110540-r adds
- new WindowCache metrics
- and enables using strong references to reference cache pages in the
WindowCache. Set core.packedGitUseStrongRefs = true to enable using
strong references to reference packfile pages cached in the WindowCache.
If this option is set Java gc can no longer flush the WindowCache to
free memory if the used heap comes close to the maximum heap size. On
the other hand this provides more predictable performance.
Documentation of core.packedGitUseStrongRefs is added in I895369a85,
which will reach stable-3.0 by merge later.
Change-Id: I8c080a16e25678dc6aeec9c21a6029965fb1ac5b
Before this change, the hereby moved package classes were not found,
while executing plugin tests in bazel standalone mode.
Bug: Issue 12218
Change-Id: I6143263b8c1f34e30d90191a62a894c1a4658114
* stable-3.1:
Remove Powermock again
Bazel: Mark truth libraries as test only
Bump Bazel version to 2.0.0
Change-Id: I4084f22c5f7225af55b2a99decacc034dd1a1d8e
Powermock was removed by change Iafcc40d2f but was unintentionally
added back when change Ib0dd147bd was merged up from stable-2.16
(where it still exists) to later branches.
Change-Id: I1c17212208d122b7212647e84894bd5b6f69e75f
In Ibe62917e20 maven jar merging using python was replaced with
java_binary rule. Fix eclipse project generation and also clean up
left over unused import statement and script.
Change-Id: I46b14f8e8e380f38962937be253fb1b7e4fa147d
* stable-3.1:
Update highlight.js
Add "Page ..." next to back and forward arrows
Fix the size of the commit message box
Bazel: Fix issues flagged by buildifier
Document that gerrit supports JDK 11
lib/lucene: merge jars using a java_binary rule
Change-Id: I9807d05de588e8437310ade18e2e5e9c84d2fe27
* stable-2.16:
Update highlight.js
Bazel: Fix issues flagged by buildifier
Document that gerrit supports JDK 11
lib/lucene: merge jars using a java_binary rule
Adjust Documentation/licenses.txt to reflect new name of merged Lucene
library due to "lib/lucene: merge jars using a java_binary rule".
Change-Id: Iae42e901c8756e46effd1302df9449e37c52f262
Fixes we want:
* fix(makefile) fix double relevance for assignments
* (xml) expand and improve document type highlighting
* fix(kotlin): fix termination of """ string literals
* (cpp) Add additional keywords
* Backslash is not used to escape in strings in standard SQL
* (javascript) fix jsx self-closing tag issues
* enh(ini) support arrays and much cleaner grammar
* (javascript) support jsx fragments
Updates to commit: 42f1df4d391126e9135d7c7a6e27931ca85c709e
Change-Id: I6fd8cc6b6527e73f8502d65caff69368c9f29942
In I42fd1a130e ("Merge Lucene core and backward-codecs jars"), Dave
Borowitz introduced a script to concatenate META-INF/services/ files
for Codecs.
Buck would randomly pick one of the two service files. The solution
was to explicitly pick the first entry for class files, and
concatenate service files.
In Bazel, we can have Bazel do the work of merging jars. This is done
with the java_binary rule. This concatenates the service files, and
picks a single .class file from each input jar, as determined by the
ordering in the jars attribute.
Delete tools/merge_jars.py, as this was its only use. This also fixes
an issue where Mac users need to specify --host_force_python=PY2 if
they don't have Python 3.
Change-Id: Ibe62917e20eeb1824967782d4d510f3f63775fce
To support tests execution on Java 11, without using Java 11 toolchain
additional parameters must be passed. The use case is building on host
Java 11. This is needed to bump host Java version to Java 11 on Gerrit
CI.
Test Plan:
1. Install Java 11 (only)
$ java -fullversion
openjdk full version "11.0.5+10-post-Debian-1deb10u1"
2. Execute tests and confirm that all tests are passing
$ bazelisk test //...
Change-Id: I97c244052f353eb61053a5f4f36a5ee646b8be9c
* stable-2.16:
Switch PatchListCache to using legacy cache backend
Replace guava caches with caffeine
Add caffeine and caffeine-guava to Documentation/licenses.txt
which did not exist on earlier branches.
Change-Id: I40fb2798a8b6eda2e92e4409c1e57042a8e59ef4
Replacing Guava caches with Caffeine reduces the chances of having the
deadlocks and improves the cache performance.
This was already attempted in: I8d2b17a94d0, but got reverted in:
If65560b4a9b due to recursion in PatchListLoader. This recursion issue
is present on current master. While this change replaces all caches
with Caffeine backend, the follow-up change in this series will switch
back to using Guava backend for PatchListCache implementation.
For seamless integration, the caffeine-guava adapter library is used.
Given that the final artifact for the adapter is also called guava,
there is only the version number that differentiates that artifact from
the guava library itself so that we have a danger for naming collision.
To avoid potential naming collision risk, rename the library name to
caffeine-guava.jar during the fetch from Maven Central.
Alternatives considered is not to use the caffeine-guava adapter
library. But then the Cache and LoadingCache classes and friends would
change the package name from com.google.common.cache package to
com.github.benmanes.caffeine.cache package and this change would also
affect some gerrit plugins and thus considered to be a quite intrusive
change. Still we can consider to do this change in one of the future
gerrit releases.
Bug: Issue 7645
Bug: Issue 11484
Change-Id: I6af4c15d6c15f438becd62409b7d233c309be8de
(cherry picked from commit 0050a9b5f61da67a9f33fda0bb170f8b1df6080a)
* stable-3.1:
Update paper-styles to a6c207e6eee3402fd7a6550e6f9c387ca22ec4c4
Update 'font-roboto' to 'font-roboto-local' in license files
Update paper-styles to dd0b13e186b9690d5e74a93f6e51e0835ea60495
Change on-tap to on-click for iron-dropdown
Fix reporting for flaky builds in Jenkinsfile
Change-Id: I9a319fbe4a7d6995c3338c861f487358703eb9f9
This includes a fix to stop using google fonts external resource
and rather use local fonts.
Bug: Issue 11993
Change-Id: I731e54ca872a2430461bc4de7d3c2dfe6d56062e
* stable-2.16:
Update paper-styles to dd0b13e186b9690d5e74a93f6e51e0835ea60495
Fix reporting for flaky builds in Jenkinsfile
Change-Id: Ibcf36ab82b85684baf8c442eddc81fee66320341
This includes a fix to stop using google fonts external resource
and rather use local fonts.
Bug: Issue 11993
Change-Id: I731e54ca872a2430461bc4de7d3c2dfe6d56062e
Some of the plugins, most notably checks plugin, may want to use
java_doc Starlark rule and for that access to //lib:javax-annotation
is required.
Change-Id: Iddc907138f71fded02c76136f34e17070dc64d18
Replacing Guava caches with Caffeine reduces the chances of having the
deadlocks and improves the cache performance.
This was already attempted in: I8d2b17a94d0, but got reverted in:
If65560b4a9b due to recursion in PatchListLoader. This recursion issue
is present on current master. While this change replaces all caches
with Caffeine backend, the follow-up change in this series will switch
back to using Guava backend for PatchListCache implementation.
For seamless integration, the caffeine-guava adapter library is used.
Given that the final artifact for the adapter is also called guava,
there is only the version number that differentiates that artifact from
the guava library itself so that we have a danger for naming collision.
To avoid potential naming collision risk, rename the library name to
caffeine-guava.jar during the fetch from Maven Central.
Alternatives considered is not to use the caffeine-guava adapter
library. But then the Cache and LoadingCache classes and friends would
change the package name from com.google.common.cache package to
com.github.benmanes.caffeine.cache package and this change would also
affect some gerrit plugins and thus considered to be a quite intrusive
change. Still we can consider to do this change in one of the future
gerrit releases.
Bug: Issue 7645
Bug: Issue 11484
Change-Id: I6af4c15d6c15f438becd62409b7d233c309be8de
* stable-3.1:
Set version to 3.1.1-SNAPSHOT
Set version to 3.1.0
Upgrade JGit to latest master
Upgrade gitiles-servlet and blame-cache to 0.3-6
Add sshd-common to lib/nongoogle_test.sh
Increase 'execution.defaultThreadPoolSize' default and min to 2
Upgrade gitiles-servlet and blame-cache to 0.2-11
Fix formatting of submission IDs
LazyPostReceiveHookChain: Simplify check for pack size
Update highlight.js
ChangeNotesParser: Skip parsing meta data of deleted patch sets
Add a --header-box-shadow theme css variable
Don't allow "show 2 more" reviewers
Bazel: Expedite the LC process
Update Jgit to latest master revision
Move tooltip to below the button for change detail actions
LazyPostReceiveHookChain: Catch IllegalStateException on ReceivePack.getPackSize
Change-Id: I8e118de48a692ef60171d4f4d26f69bafb330c70
Continuation is deprecated in Jetty 9.4 and removed in Jetty 10. Migrate
ProjectQoSFilter to use javax.servlet.AsyncContext instead.
Change-Id: I398fca0f75b675ad683a6d4c572ffb844c23e364